Skip to content

ROX-32329: Remove Scanner V2 from Konflux builds - #22550

Closed
msugakov wants to merge 2 commits into
masterfrom
misha/ROX-32329-remove-scanner-v2-from-Konflux-build
Closed

msugakov wants to merge 2 commits into
masterfrom
misha/ROX-32329-remove-scanner-v2-from-Konflux-build

Conversation

@msugakov

@msugakov msugakov commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Description

See the ticket.
Goes after #22551.

User-facing documentation

  • CHANGELOG.md is updated OR update is not needed I hope someone in the parent ticket addresses it.
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

By checking that Konflux build CI is green.

@msugakov msugakov added the konflux-build Run Konflux in PR. Push commit to trigger it. label Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 452fa735-370b-4d17-a523-d0e30b25a913

📥 Commits

Reviewing files that changed from the base of the PR and between aa83283 and 0892132.

📒 Files selected for processing (1)
  • operator/konflux.bundle.Dockerfile
💤 Files with no reviewable changes (1)
  • operator/konflux.bundle.Dockerfile

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Removed legacy Scanner image mappings from snapshot creation.
    • Removed legacy Scanner image parameters and image-wait steps from bundle builds.
    • Removed automated retagging configurations for Scanner and Scanner database images.
    • Scanner V4 and other related-image configurations remain unchanged.

Walkthrough

The change removes legacy Scanner V2 image mappings and build configuration. It also deletes four Scanner retag PipelineRun definitions and removes Scanner V2 parameters, wait tasks, and related-image arguments from the operator bundle pipeline.

Changes

Scanner V2 pipeline removal

Layer / File(s) Summary
Remove Scanner V2 pipeline and snapshot wiring
.tekton/create-custom-snapshot.yaml, .tekton/operator-bundle-pipeline.yaml, .tekton/retag-scanner*.yaml
The ACS snapshot configuration no longer includes Scanner V2 image mappings. The operator bundle pipeline no longer defines Scanner V2 image parameters, wait tasks, or related-image build arguments. Four Scanner retag PipelineRun definitions were deleted.
Remove Scanner V2 bundle image configuration
operator/konflux.bundle.Dockerfile
The bundle Dockerfile no longer declares, assigns, or validates legacy Scanner V2 image arguments. Scanner V4 configuration remains.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: tommartensen

Merge Risk: ⚪ Minimal · up to 08921

This PR removes Scanner V2 components from Konflux build configuration. No actionable merge-blocking risk remains; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies the main change: removing Scanner V2 from Konflux builds.
Description check ✅ Passed The description covers the change, documentation status, production readiness, testing status, and validation method. It notes that CI results were not inspected and that changelog handling is deferre…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch misha/ROX-32329-remove-scanner-v2-from-Konflux-build

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.38%. Comparing base (2bdd164) to head (0892132).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22550      +/-   ##
==========================================
- Coverage   51.42%   51.38%   -0.05%     
==========================================
  Files        2876     2876              
  Lines      180446   180446              
==========================================
- Hits        92799    92714      -85     
- Misses      79560    79620      +60     
- Partials     8087     8112      +25     
Flag Coverage Δ
go-unit-tests 51.38% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 0892132. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.0.x-137-g0892132084

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

2 similar comments
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-bundle-on-push

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-index-on-push

2 similar comments
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-index-on-push

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest operator-index-on-push

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest create-custom-snapshot

2 similar comments
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest create-custom-snapshot

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

/konflux-retest create-custom-snapshot

@mclasmeier mclasmeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, what about .tekton/images-mirror-set.yaml?

@msugakov

Copy link
Copy Markdown
Contributor Author

Replaced by #22822

@msugakov msugakov closed this Sep 14, 2026
@msugakov
msugakov deleted the misha/ROX-32329-remove-scanner-v2-from-Konflux-build branch September 14, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/operator do-not-merge/work-in-progress konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants