Skip to content

ROX-34952: implement container type filter in CompileEvaluationFilter#21062

Open
AlexVulaj wants to merge 1 commit into
masterfrom
AlexVulaj/ROX-34952-container-type-filter-logic
Open

ROX-34952: implement container type filter in CompileEvaluationFilter#21062
AlexVulaj wants to merge 1 commit into
masterfrom
AlexVulaj/ROX-34952-container-type-filter-logic

Conversation

@AlexVulaj

@AlexVulaj AlexVulaj commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Implements the container type filter in CompileEvaluationFilter. When a policy's EvaluationFilter has skip_container_types set, the compiled filter strips matching containers (and their corresponding images) before policy evaluation. Uses the same clone-and-filter pattern as the existing filterInitContainers() function.

Stacked on #21043.

User-facing documentation

  • CHANGELOG.md is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: gated behind ROX_EVALUATION_FILTER feature flag
  • CI results are inspected

Automated testing

  • added unit tests

How I validated my change

Unit tests covering: skip init containers, skip regular containers, no-op when no matching containers present, nil/empty proto returns no filter, feature flag disabled returns nil.

@AlexVulaj AlexVulaj requested a review from a team as a code owner June 10, 2026 16:04
@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 70b0f61. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-145-g70b0f61d58

@AlexVulaj AlexVulaj force-pushed the AlexVulaj/ROX-34952-container-type-filter-logic branch from 67532d5 to 89c9c31 Compare June 10, 2026 16:14
@coderabbitai

coderabbitai Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: a4198b5a-4afd-4a48-9990-3632716731d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch AlexVulaj/ROX-34952-container-type-filter-logic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from AlexVulaj/ROX-34951-eval-filter-container-type to master June 10, 2026 19:06
@AlexVulaj

AlexVulaj commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/test gke-nongroovy-e2e-tests

@AlexVulaj AlexVulaj force-pushed the AlexVulaj/ROX-34952-container-type-filter-logic branch from 89c9c31 to 70b0f61 Compare June 10, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlexVulaj