Skip to content

ROX-34994: Add ROX_VULN_MGMT_DATE_RANGE_FILTER feature flag#21049

Merged
sachaudh merged 1 commit into
masterfrom
ROX-34994-date-range-filter-flag
Jun 10, 2026
Merged

ROX-34994: Add ROX_VULN_MGMT_DATE_RANGE_FILTER feature flag#21049
sachaudh merged 1 commit into
masterfrom
ROX-34994-date-range-filter-flag

Conversation

@sachaudh

@sachaudh sachaudh commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Jira: ROX-34994

I'm starting on date/time range filtering for the VM 2.0 advanced filters (a "Between" condition on the date-picker attributes, plus retargeting the Aging Images dashboard widget from VM 1.0 to VM 2.0). I'm planning to land that work in incremental PRs, so this first one just adds the feature flag to keep the in-progress pieces hidden until everything is ready. I followed the same pattern we used in #19929 for ROX_NODE_VULNERABILITY_REPORTS.

  • Registered VulnMgmtDateRangeFilter (ROX_VULN_MGMT_DATE_RANGE_FILTER) in pkg/features/list.go, disabled by default
  • Enabled the flag in CI e2e runs (tests/e2e/lib.sh: export_test_environment and deploy_central_via_operator)
  • Added the flag to the FeatureFlagEnvVar union in the UI (types/featureFlag.ts)

Nothing reads the flag yet, so there's no behavior change anywhere with this PR.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

I didn't check any boxes here since this is flag registration only, with no new logic to test. The flag's actual behavior will get unit and component tests in the follow-up PRs that consume it.

How I validated my change

  • Ran go build ./pkg/features/... and go test ./pkg/features/..., both pass
  • Ran bash -n tests/e2e/lib.sh to syntax-check the shell changes
  • Ran eslint src/types/featureFlag.ts, no issues
  • No UI validation here since nothing reads the flag yet (there's nothing visible to check)

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: e1bb61b3-26bd-40d5-a2f9-7dacb5e2470e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ROX-34994-date-range-filter-flag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sachaudh sachaudh marked this pull request as ready for review June 9, 2026 21:16
@sachaudh sachaudh requested review from a team as code owners June 9, 2026 21:16
@github-actions

github-actions Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 831ef90. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-129-g831ef90243

@sachaudh
ROX-34994: Add ROX_VULN_MGMT_DATE_RANGE_FILTER feature flag
212f342 
Date/time range filtering for VM 2.0 advanced filters will land in
increments, so gate the upcoming "Between" condition and the Aging
Images widget retarget behind a flag that is disabled by default in
production and enabled in CI e2e runs, following the same pattern as
ROX_NODE_VULNERABILITY_REPORTS (#19929).

Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
@sachaudh sachaudh force-pushed the ROX-34994-date-range-filter-flag branch from f1fbca9 to 212f342 Compare June 9, 2026 23:29
@sachaudh sachaudh mentioned this pull request Jun 10, 2026
Open
5 tasks
@sachaudh sachaudh merged commit 831ef90 into master Jun 10, 2026
109 checks passed
@sachaudh sachaudh deleted the ROX-34994-date-range-filter-flag branch June 10, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrottimark pedrottimark pedrottimark approved these changes

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sachaudh @pedrottimark