ROX-34994: Add ROX_VULN_MGMT_DATE_RANGE_FILTER feature flag#21048
ROX-34994: Add ROX_VULN_MGMT_DATE_RANGE_FILTER feature flag#21048sachaudh wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sachaudh
changed the title
Date/time range filtering for VM 2.0 advanced filters will land in increments, so gate the upcoming "Between" condition and the Aging Images widget retarget behind a flag that is disabled by default in production and enabled in CI e2e runs, following the same pattern as ROX_NODE_VULNERABILITY_REPORTS (#19929). Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
sachaudh
force-pushed
the
ROX-28073-date-range-filter-flag
branch
from
25c3109 to
f1fbca9
Compare
|
Closing in favor of a recreated PR from a branch named for the correct ticket (ROX-34994). |
🚀 Build Images ReadyImages are ready for commit f1fbca9. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-110-gf1fbca9c63 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21048 +/- ##
==========================================
- Coverage 49.86% 49.83% -0.03%
==========================================
Files 2812 2812
Lines 215112 215115 +3
==========================================
- Hits 107256 107211 -45
- Misses 100039 100069 +30
- Partials 7817 7835 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Description
Jira: ROX-34994
I'm starting on date/time range filtering for the VM 2.0 advanced filters (a "Between" condition on the date-picker attributes, plus retargeting the Aging Images dashboard widget from VM 1.0 to VM 2.0). I'm planning to land that work in incremental PRs, so this first one just adds the feature flag to keep the in-progress pieces hidden until everything is ready. I followed the same pattern we used in #19929 for
ROX_NODE_VULNERABILITY_REPORTS.VulnMgmtDateRangeFilter(ROX_VULN_MGMT_DATE_RANGE_FILTER) inpkg/features/list.go, disabled by defaulttests/e2e/lib.sh:export_test_environmentanddeploy_central_via_operator)FeatureFlagEnvVarunion in the UI (types/featureFlag.ts)Nothing reads the flag yet, so there's no behavior change anywhere with this PR. On the name: I went with the
VULN_MGMTprefix to matchROX_VULN_MGMT_LEGACY_SNOOZE, since "VM" already means virtual machines inlist.go(ROX_VIRTUAL_MACHINES*).User-facing documentation
Testing and quality
Automated testing
I didn't check any boxes here since this is flag registration only, with no new logic to test. The flag's actual behavior will get unit and component tests in the follow-up PRs that consume it.
How I validated my change
go build ./pkg/features/...andgo test ./pkg/features/..., both passbash -n tests/e2e/lib.shto syntax-check the shell changeseslint src/types/featureFlag.ts, no issues