Skip to content

ROX-34951: add skip_container_types field to EvaluationFilter proto#21043

Merged
AlexVulaj merged 1 commit into
masterfrom
AlexVulaj/ROX-34951-eval-filter-container-type
Jun 10, 2026
Merged

ROX-34951: add skip_container_types field to EvaluationFilter proto#21043
AlexVulaj merged 1 commit into
masterfrom
AlexVulaj/ROX-34951-eval-filter-container-type

Conversation

@AlexVulaj

@AlexVulaj AlexVulaj commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Adds skip_container_types field to the EvaluationFilter meessage in policy.proto, reusing the existing ContainerType enum from deployment.proto. This allows policies to specify which container types to skip during evaluation (e.g. skip init containers).

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

@AlexVulaj AlexVulaj requested a review from a team as a code owner June 9, 2026 17:20
@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 6818d7ab-3b0b-4af1-a793-7fc87a9b796e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch AlexVulaj/ROX-34951-eval-filter-container-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit d224e91. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-144-gd224e91580

@AlexVulaj AlexVulaj force-pushed the AlexVulaj/ROX-34951-eval-filter-container-type branch from 7d6e624 to df19b19 Compare June 9, 2026 17:36
Base automatically changed from cong/eval-filter to master June 9, 2026 22:29
@c-du c-du requested a review from a team as a code owner June 9, 2026 22:29
@AlexVulaj AlexVulaj force-pushed the AlexVulaj/ROX-34951-eval-filter-container-type branch from df19b19 to 6539bee Compare June 10, 2026 14:03
@AlexVulaj AlexVulaj mentioned this pull request Jun 10, 2026
Open
5 tasks
@AlexVulaj AlexVulaj merged commit d224e91 into master Jun 10, 2026
109 checks passed
@AlexVulaj AlexVulaj deleted the AlexVulaj/ROX-34951-eval-filter-container-type branch June 10, 2026 19:06
@AlexVulaj AlexVulaj restored the AlexVulaj/ROX-34951-eval-filter-container-type branch June 10, 2026 19:06
@AlexVulaj AlexVulaj deleted the AlexVulaj/ROX-34951-eval-filter-container-type branch June 10, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-du c-du c-du approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexVulaj @c-du