feat(ci): enable OCP-ECR image cred for prefetcher#21031
Conversation
Bump image-prefetcher/deploy to feat/ocp-credential-provider branch which adds OCP-ECR as an accepted value for --use-kubelet-image-credential-integration. When the image prefetcher runs on OCP clusters backed by AWS, detect the platform via `oc get infrastructure cluster` and pass OCP-ECR so that ECR credentials are available for image pulls. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🚀 Build Images ReadyImages are ready for commit 2b333ee. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-121-g2b333ee5a6 |
Append the ECR test image used by ImageScanningTest.groovy to the prefetch list at runtime when AWS_ECR_REGISTRY_NAME and AWS_ECR_REGISTRY_REGION env vars are available. The image reference is dynamic (registry ID and region come from vault secrets) so it cannot be added to the static images-to-prefetch.txt. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 participant
Description
Enable the image prefetcher to use OCP-ECR kubelet image credential provider
integration when running on OCP clusters backed by AWS. This lets ECR
credentials flow through to image pulls without a separate pull secret.
Changes:
image-prefetcher/deploytofeat/ocp-credential-providerbranch(adds
OCP-ECRas an accepted--use-kubelet-image-credential-integrationvalue) in feat: add OCP modes for kubelet credential provider integration image-prefetcher#196oc get infrastructure clusterin theocp)case ofimage_prefetcher_start_setand passOCP-ECRaccordinglyUser-facing documentation
Testing and quality
Automated testing
How I validated my change
Will be validated by the OCP-on-AWS CI jobs (e.g.
cr--acs--tests-awsinocp-4.22-lpMainline-lp-ocp-compat).On non-AWS OCP clusters the behavior is unchanged (disabled). On non-OCP clusters the code path is not reached.