Skip to content

fix(tests): increase memory limits for race-detector builds#19951

Open
davdhacs wants to merge 4 commits intomasterfrom
davdhacs/fix-rcd-oom-race-overrides
Open

fix(tests): increase memory limits for race-detector builds#19951
davdhacs wants to merge 4 commits intomasterfrom
davdhacs/fix-rcd-oom-race-overrides

Conversation

@davdhacs
Copy link
Copy Markdown
Contributor

@davdhacs davdhacs commented Apr 10, 2026

Description

ROX-33958 busybox binary consolidation causes OOMKills for admission-control and config-controller in race-detector nightly builds. Increases memory limits post-deploy when IS_RACE_BUILD is set.

Testing and quality

Automated testing

  • modified existing tests

How I validated my change

Same pattern as existing OpenShift CPU override on line 424.

🤖 Generated with Claude Code

The busybox-style binary consolidation (ROX-33958) runs init() for all
components at startup. Under the race detector's ~5-10x memory multiplier
this causes OOMKills for admission-control (500Mi limit) and
config-controller (128Mi limit).

Override memory limits post-deploy when IS_RACE_BUILD is set, following
the same pattern used for OpenShift CPU overrides (ROX-5334).

- config-controller: 128Mi → 512Mi (race builds only)
- admission-control: 500Mi → 2Gi (race builds only)

Default Helm chart values are unchanged.

Generated with assistance from AI

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 10, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@davdhacs davdhacs marked this pull request as ready for review April 10, 2026 22:09
@davdhacs davdhacs requested review from dashrews78 and janisz April 10, 2026 22:09
@davdhacs davdhacs added the ci-race-tests Uses a `-race` build for all e2e tests label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

🚀 Build Images Ready

Images are ready for commit 1ee3f01. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-630-g1ee3f01197

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.56%. Comparing base (4a13459) to head (9328fc6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19951   +/-   ##
=======================================
  Coverage   49.56%   49.56%           
=======================================
  Files        2764     2764           
  Lines      208357   208357           
=======================================
  Hits       103269   103269           
  Misses      97436    97436           
  Partials     7652     7652           
Flag Coverage Δ
go-unit-tests 49.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

davdhacs and others added 2 commits April 10, 2026 23:39
…yment

The config-controller deployment names its container 'manager', not
'config-controller'.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… resources

The operator reconciles and reverts kubectl resource overrides. For
operator-managed deployments (OCP jobs), patch the Central/SecuredCluster
CRs directly. For helm/kubectl deployments (GKE jobs), keep using
kubectl set resources.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@davdhacs
Copy link
Copy Markdown
Contributor Author

/test gke-qa-e2e-tests

@davdhacs davdhacs added the auto-retest PRs with this label will be automatically retested if prow checks fails label Apr 12, 2026
@davdhacs
Copy link
Copy Markdown
Contributor Author

davdhacs commented Apr 12, 2026

/retest-required

@rhacs-bot
Copy link
Copy Markdown
Contributor

/retest

3 similar comments
@rhacs-bot
Copy link
Copy Markdown
Contributor

/retest

@rhacs-bot
Copy link
Copy Markdown
Contributor

/retest

@rhacs-bot
Copy link
Copy Markdown
Contributor

/retest

@davdhacs davdhacs removed the auto-retest PRs with this label will be automatically retested if prow checks fails label Apr 12, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 12, 2026

@davdhacs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-scanner-v4-install-tests 9328fc6 link false /test ocp-4-12-scanner-v4-install-tests
ci/prow/ocp-4-21-scanner-v4-install-tests 9328fc6 link false /test ocp-4-21-scanner-v4-install-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@davdhacs davdhacs force-pushed the davdhacs/fix-rcd-oom-race-overrides branch from 9328fc6 to 1ee3f01 Compare April 12, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted ci-race-tests Uses a `-race` build for all e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants