ROX-34000: fix reencrypt route with custom cert#19866
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
stehessel
added
backport release-4.10
backport release-4.9
Contributor
🚀 Build Images ReadyImages are ready for commit 27bf450. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-582-g27bf450c18 |
mclasmeier
reviewed
Apr 7, 2026
pkg/helm/charts/tests/centralservices/testdata/helmtest/openshift-routes.test.yaml
Show resolved
Hide resolved
mclasmeier
reviewed
Apr 7, 2026
pkg/helm/charts/tests/centralservices/testdata/helmtest/openshift-routes.test.yaml
Outdated
Show resolved
Hide resolved
Changed test name from "reencrypt route without custom certificate uses OpenShift CA" to "reencrypt route without custom cert has empty cert fields" to better describe what the test actually verifies. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19866 +/- ##
==========================================
- Coverage 49.60% 49.58% -0.02%
==========================================
Files 2763 2766 +3
Lines 208331 208530 +199
==========================================
+ Hits 103340 103408 +68
- Misses 97325 97449 +124
- Partials 7666 7673 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-4.8 release-4.8
# Navigate to the new working tree
cd .worktrees/backport-release-4.8
# Create a new branch
git switch --create backport-19866-to-release-4.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 27bf450c18afa12d4908fe372271944264f6e955
# Push it to GitHub
git push --set-upstream origin backport-19866-to-release-4.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-4.8Then, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-4.9 release-4.9
# Navigate to the new working tree
cd .worktrees/backport-release-4.9
# Create a new branch
git switch --create backport-19866-to-release-4.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 27bf450c18afa12d4908fe372271944264f6e955
# Push it to GitHub
git push --set-upstream origin backport-19866-to-release-4.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-4.9Then, create a pull request where the |
rhacs-bot
pushed a commit
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a faulty Helm chart linter, which led to a valid reencrypt route configuration being rejected. The linter is supposed to fail configurations which specify only one of
tls.certificateortls.key, while leaving the other empty. However, the actual behavior is that valid configs, with bothtls.certificateandtls.keyspecified, are also rejected.User-facing documentation
Testing and quality
Automated testing
How I validated my change
created a helm config with both cert and key and confirmed that it deploys successfully: