Skip to content

ROX-33979: external diagnostic stats fix #19859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dashrews78 merged 2 commits into from
Apr 7, 2026
+5 −3
Merged

ROX-33979: external diagnostic stats fix #19859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36a6ba
X-Smart-Branch-Parent: master
dashrews78 Apr 6, 2026
f976472
fix: use pg_stat_user_tables for diagnostic bundle analyze stats
dashrews78 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/postgres/stats/stats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,12 @@ type PGAnalyzeStats struct {
Error string
}

// GetPGAnalyzeStats returns a tuple struct that wraps the results from the query to pg_stat_all_tables
// GetPGAnalyzeStats returns a tuple struct that wraps the results from the query to pg_stat_user_tables.
// pg_stat_user_tables is used instead of pg_stat_all_tables because external database instances
// may not grant access to pg_stat_all_tables.
func GetPGAnalyzeStats(ctx context.Context, db postgres.DB, limit int) *PGAnalyzeStats {
var analyzeStats PGAnalyzeStats
rows, err := db.Query(ctx, "SELECT relname, last_autoanalyze, last_analyze, last_autovacuum, last_vacuum FROM pg_stat_all_tables WHERE schemaname = $1 ORDER BY relname limit $2", "public", limit)
rows, err := db.Query(ctx, "SELECT relname, last_autoanalyze, last_analyze, last_autovacuum, last_vacuum FROM pg_stat_user_tables ORDER BY relname LIMIT $1", limit)
if err != nil {
analyzeStats.Error = err.Error()
return &analyzeStats
Expand All @@ -120,7 +122,7 @@ func GetPGAnalyzeStats(ctx context.Context, db postgres.DB, limit int) *PGAnalyz
for rows.Next() {
var analyzeStat PGAnalyzeStat
if err := rows.Scan(&analyzeStat.TableName, &analyzeStat.LastAutoAnalyze, &analyzeStat.LastAnalyze, &analyzeStat.LastAutoVacuum, &analyzeStat.LastVacuum); err != nil {
analyzeStats.Error = errors.Wrap(err, "error scanning rows from pg_stat_all_tables").Error()
analyzeStats.Error = errors.Wrap(err, "error scanning rows from pg_stat_user_tables").Error()
return &analyzeStats
}
analyzeStats.AnalyzeStats = append(analyzeStats.AnalyzeStats, &analyzeStat)
Expand Down
Loading