Skip to content

ROX-33979: external diagnostic stats fix#19859

Merged
dashrews78 merged 2 commits intomasterfrom
dashrews/external-diagnostic-stats-fix-33979
Apr 7, 2026
Merged

ROX-33979: external diagnostic stats fix#19859
dashrews78 merged 2 commits intomasterfrom
dashrews/external-diagnostic-stats-fix-33979

Conversation

@dashrews78
Copy link
Copy Markdown
Contributor

@dashrews78 dashrews78 commented Apr 7, 2026 •
edited
Loading

Description

use pg_stat_user_tables for diagnostic bundle analyze stats
pg_stat_all_tables requires elevated privileges that external database
instances may not grant. pg_stat_user_tables returns the same data for
tables owned by the current user without requiring additional grants.

Partially generated by AI.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

spun up BYODB cluster and verified via the diagnostic bundle.

dashrews78 and others added 2 commits April 6, 2026 15:59
@dashrews78
X-Smart-Branch-Parent: master
b36a6ba
@dashrews78 @claude
fix: use pg_stat_user_tables for diagnostic bundle analyze stats
f976472 
pg_stat_all_tables requires elevated privileges that external database
instances may not grant. pg_stat_user_tables returns the same data for
tables owned by the current user without requiring additional grants.

Partially generated by AI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

🚀 Build Images Ready

Images are ready for commit e037ba4. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-584-ge037ba4575

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.60%. Comparing base (4c51907) to head (f976472).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19859      +/-   ##
==========================================
- Coverage   49.60%   49.60%   -0.01%     
==========================================
  Files        2763     2763              
  Lines      208339   208331       -8     
==========================================
- Hits       103344   103336       -8     
+ Misses      97330    97328       -2     
- Partials     7665     7667       +2
Flag Coverage Δ
go-unit-tests 49.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dashrews78 dashrews78 marked this pull request as ready for review April 7, 2026 16:14
@dashrews78 dashrews78 requested a review from a team as a code owner April 7, 2026 16:14
@dashrews78
Copy link
Copy Markdown
Contributor Author

dashrews78 commented Apr 7, 2026

/test gke-operator-e2e-tests

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2026

@dashrews78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests f976472 link false /test ocp-4-12-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dashrews78 dashrews78 merged commit e037ba4 into master Apr 7, 2026
113 of 114 checks passed
@dashrews78 dashrews78 deleted the dashrews/external-diagnostic-stats-fix-33979 branch April 7, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-du c-du c-du approved these changes

@charmik-redhat charmik-redhat charmik-redhat approved these changes

Assignees

No one assigned

Labels

area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dashrews78 @c-du @charmik-redhat