Skip to content

ROX-32714: Do not write empty image id from cve and component stores #19843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charmik-redhat merged 1 commit into from
Apr 7, 2026
Merged

ROX-32714: Do not write empty image id from cve and component stores #19843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions central/cve/image/v2/datastore/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions central/imagecomponent/v2/datastore/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/storage/cve.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/storage/image_component.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/storage/cve.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ message ImageCVEV2 {
// within the component
string id = 1; // @gotags: search:"CVE ID,hidden" sql:"pk,id"
// was hash index, making it btree
string image_id = 2 [deprecated = true]; // @gotags: sql:"fk(Image:id),index=btree"
string image_id = 2 [deprecated = true]; // @gotags: sql:"fk(Image:id),index=btree,allow-null"
CVEInfo cve_base_info = 3;
// cvss stores ACS preferred cvss score
float cvss = 4; // @gotags: search:"CVSS"
Expand Down
2 changes: 1 addition & 1 deletion proto/storage/image_component.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ message ImageComponentV2 {
string fixed_by = 8;
string operating_system = 9; // @gotags: search:"Operating System"
// was hash index, making it btree
string image_id = 10 [deprecated = true]; // @gotags: sql:"fk(Image:id),index=btree"
string image_id = 10 [deprecated = true]; // @gotags: sql:"fk(Image:id),index=btree,allow-null"
/// Layer that contains this component
oneof has_layer_index {
int32 layer_index = 11;
Expand Down
Loading