sensor/common/reprocessor/handler_test.go (1)

32-43: This test doesn't currently prove the TTL was refreshed.

Because newTestCache hardcodes a real one-hour cache and the assertions run immediately after ProcessRefreshImageCacheTTL, this would still pass for a no-op. Consider using a controllable clock or a very short TTL and asserting that refreshed keys survive past the original expiry while untouched keys do not.

Also applies to: 125-191

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@sensor/common/reprocessor/handler_test.go` around lines 32 - 43, The test
never verifies TTL refresh because newTestCache() creates a fixed 1-hour cache
and assertions run immediately; change the tests to use a controllable/short TTL
and advance time to observe expiry. Modify newTestCache to accept a TTL (or a
clock) parameter and construct the expiring cache with that TTL (or pass a mock
clock), then in the tests that call ProcessRefreshImageCacheTTL (and the block
around lines 125-191) create the cache with a very short TTL (e.g., 10–50ms) or
a fake clock, call ProcessRefreshImageCacheTTL, advance the clock (or sleep)
past the original TTL for non-refreshed keys, and assert refreshed keys still
exist while untouched keys have expired; refer to newTestCache and
ProcessRefreshImageCacheTTL to locate the changes.

sensor/common/reprocessor/handler.go (1)

95-97: Align empty-key handling with refresh path.

On Line 96, invalidation appends keys unconditionally, while the refresh handler skips empty keys. Filtering here too improves behavioral consistency and avoids acting on empty cache keys.

Suggested change

 		keysToDelete := make([]cache.Key, 0, len(req.GetImageKeys()))
 		for _, image := range req.GetImageKeys() {
-			keysToDelete = append(keysToDelete, cacheKeyFromImageKey(image))
+			if key := cacheKeyFromImageKey(image); key != "" {
+				keysToDelete = append(keysToDelete, key)
+			}
 		}
 		h.imageCache.Remove(keysToDelete...)

As per coding guidelines, "Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@sensor/common/reprocessor/handler.go` around lines 95 - 97, The invalidation
loop appends cache keys unconditionally; align it with the refresh path by
skipping empty keys — call cacheKeyFromImageKey(image) and only append to
keysToDelete when the returned cache key is non-empty (i.e., if cacheKey == ""
continue). Update the loop that iterates req.GetImageKeys() so it filters out
empty cache keys before appending to keysToDelete.