Skip to content

ROX-33792: perf(build): combine roxctl and roxagent builds per arch #19781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janisz wants to merge 1 commit into from
Closed

ROX-33792: perf(build): combine roxctl and roxagent builds per arch #19781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,10 +385,20 @@ build-prep: deps
.PHONY: roxctl-build
roxctl-build: roxctl-linux roxctl-darwin roxctl-windows

roxctl-linux: roxctl_linux-amd64 roxctl_linux-arm64 roxctl_linux-ppc64le roxctl_linux-s390x
roxctl-linux: cli_linux-amd64 cli_linux-arm64 cli_linux-ppc64le cli_linux-s390x
roxctl-darwin: roxctl_darwin-amd64 roxctl_darwin-arm64
roxctl-windows: roxctl_windows-amd64

# Combined Linux builds - more efficient than separate invocations
cli_linux-%: build-prep
$(eval arch := $*)
ifdef SKIP_CLI_BUILD
test -f bin/linux_$(arch)/roxctl -a -f bin/linux_$(arch)/roxagent || \
RACE=0 CGO_ENABLED=0 GOOS=linux GOARCH=$(arch) $(GOBUILD) ./roxctl ./compliance/virtualmachines/roxagent
else
RACE=0 CGO_ENABLED=0 GOOS=linux GOARCH=$(arch) $(GOBUILD) ./roxctl ./compliance/virtualmachines/roxagent
endif

roxctl_%: build-prep
$(eval w := $(subst -, ,$*))
$(eval os := $(firstword $(w)))
Expand All @@ -413,7 +423,7 @@ roxctl: roxctl-build roxctl-install
.PHONY: roxagent-build
roxagent-build: roxagent-linux

roxagent-linux: roxagent_linux-amd64 roxagent_linux-arm64 roxagent_linux-ppc64le roxagent_linux-s390x
roxagent-linux: cli_linux-amd64 cli_linux-arm64 cli_linux-ppc64le cli_linux-s390x

roxagent_%: build-prep
$(eval w := $(subst -, ,$*))
Expand Down
Loading