Skip to content

docs(go): Add docstrings to phonehome telemetry methods#19777

Merged
parametalol merged 2 commits intomasterfrom
coderabbitai/docstrings/117a534
Apr 8, 2026
Merged

docs(go): Add docstrings to phonehome telemetry methods#19777
parametalol merged 2 commits intomasterfrom
coderabbitai/docstrings/117a534

Conversation

@coderabbitai
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot commented Apr 2, 2026

Docstrings generation was requested by @parametalol.

The following files were modified:

  • central/telemetry/centralclient/interceptors.go
  • pkg/telemetry/phonehome/campaign.go
  • pkg/telemetry/phonehome/headers_multimap.go
  • pkg/telemetry/phonehome/interceptor.go
These files were ignored
  • central/telemetry/centralclient/interceptors_test.go
  • pkg/telemetry/phonehome/campaign_test.go
  • pkg/telemetry/phonehome/headers_multimap_test.go
  • pkg/telemetry/phonehome/interceptor_test.go
  • pkg/telemetry/phonehome/request_params_test.go
ℹ️ Note

CodeRabbit cannot perform edits on its own pull requests yet.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 2, 2026

Hi @coderabbitai[bot]. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhacs-bot
Copy link
Copy Markdown
Contributor

Images are ready for the commit at 5672ff3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-529-g5672ff3c67.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.60%. Comparing base (d32cf0a) to head (35a90af).
⚠️ Report is 36 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19777   +/-   ##
=======================================
  Coverage   49.60%   49.60%           
=======================================
  Files        2763     2763           
  Lines      208271   208271           
=======================================
+ Hits       103309   103319   +10     
+ Misses      97294    97286    -8     
+ Partials     7668     7666    -2     
Flag Coverage Δ
go-unit-tests 49.60% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from michael/telemetry-requestparam-refactoring to master April 2, 2026 12:31
Docstrings generation was requested by @parametalol.

* #19722 (comment)

The following files were modified:

* `central/telemetry/centralclient/interceptors.go`
* `pkg/telemetry/phonehome/campaign.go`
* `pkg/telemetry/phonehome/headers_multimap.go`
* `pkg/telemetry/phonehome/interceptor.go`
@parametalol parametalol changed the title 📝 Add docstrings to michael/telemetry-requestparam-refactoring docs(go): Add docstrings to phonehome telemetry methods Apr 3, 2026
@parametalol parametalol force-pushed the coderabbitai/docstrings/117a534 branch from 5672ff3 to 08c5d1e Compare April 3, 2026 08:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

🚀 Build Images Ready

Images are ready for commit ada9a66. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.11.x-591-gada9a66516

Copy link
Copy Markdown
Contributor

@parametalol parametalol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now is ok.

@parametalol parametalol enabled auto-merge (squash) April 3, 2026 09:01
@parametalol parametalol merged commit ada9a66 into master Apr 8, 2026
99 checks passed
@parametalol parametalol deleted the coderabbitai/docstrings/117a534 branch April 8, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants