Skip to content

perf(ci): add SKIP_DEPS, split postgres targets, allow test caching#19742

Closed
davdhacs wants to merge 1 commit intomasterfrom
davdhacs/makefile-skip-deps
Closed

perf(ci): add SKIP_DEPS, split postgres targets, allow test caching#19742
davdhacs wants to merge 1 commit intomasterfrom
davdhacs/makefile-skip-deps

Conversation

@davdhacs
Copy link
Copy Markdown
Contributor

@davdhacs davdhacs commented Apr 1, 2026

Description

Backward-compatible Makefile changes that unblock CI optimization PRs:

  • SKIP_DEPS: wrap deps target in ifdef SKIP_DEPS guard. When set, skips go mod tidy for test-only jobs that don't modify dependencies. No-op unless env var is set.
  • go-postgres subtargets: split go-postgres-unit-tests into go-postgres-unit-tests-main and go-postgres-unit-tests-migrator. The umbrella target still works identically. Enables independent sharding in CI.
  • Remove -count=1 from integration-unit-tests: allows Go test cache hits for integration tests.

Split from #19678.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

All changes are backward-compatible. make go-postgres-unit-tests still runs both subtargets. SKIP_DEPS is a no-op unless explicitly set. CI validates.

🤖 Generated with Claude Code

@davdhacs @claude
perf(ci): add SKIP_DEPS, split postgres targets, allow test caching
af1275f 
- Add SKIP_DEPS guard to deps target: when set, skip go mod tidy
  for jobs that don't need it (e.g. test-only jobs).
- Split go-postgres-unit-tests into main/migrator subtargets to
  enable independent sharding in CI.
- Remove -count=1 from integration-unit-tests to allow Go test
  cache hits.

All changes are backward-compatible: existing callers work unchanged.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 1, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.59%. Comparing base (2837c9b) to head (af1275f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19742      +/-   ##
==========================================
- Coverage   49.59%   49.59%   -0.01%     
==========================================
  Files        2756     2756              
  Lines      208036   208036              
==========================================
- Hits       103183   103182       -1     
- Misses      97192    97193       +1     
  Partials     7661     7661
Flag Coverage Δ
go-unit-tests 49.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

davdhacs added a commit that referenced this pull request Apr 1, 2026
@davdhacs @claude
perf(ci): shard go and go-postgres unit test jobs
928766b 
Split the monolithic go job into 5 shards (pkg-helm, pkg-other,
central-1, central-2, rest) and go-postgres into 2 shards
(main, migrator) for parallel execution.

Also split integration and operator tests into separate jobs
(go-integration, go-operator-integration) so they run in parallel
with unit tests instead of sequentially after them.

Depends on #19743 (container removal) and #19742 (SKIP_DEPS +
postgres subtargets).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@davdhacs davdhacs mentioned this pull request Apr 1, 2026
Draft
5 tasks
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Apr 1, 2026

Images are ready for the commit at af1275f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-525-gaf1275fbdc.

@davdhacs
Copy link
Copy Markdown
Contributor Author

davdhacs commented Apr 1, 2026

Combined into #19744 (shard split PR) — the Makefile changes are a prerequisite for sharding and make more sense as one logical PR.

@davdhacs davdhacs closed this Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ai-assisted do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davdhacs @rhacs-bot