Skip to content

perf(ci): disable GOMODCACHE by default in cache-go-dependencies #19688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davdhacs merged 10 commits into from
Mar 31, 2026
Merged

perf(ci): disable GOMODCACHE by default in cache-go-dependencies #19688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ad9746b
perf(ci): add cache-mod input to disable GOMODCACHE by default
davdhacs Mar 30, 2026
e22d7fe
perf(ci): remove make deps from cache action, rely on lazy download
davdhacs Mar 30, 2026
2e62ce7
fix: download scanner module before resolving its directory
davdhacs Mar 30, 2026
2f5c9b7
fix: download scanner module in protogen.mk before resolving Dir
davdhacs Mar 30, 2026
6254b26
perf(ci): remove GOMODCACHE caching and make deps entirely
davdhacs Mar 30, 2026
0114b7d
empty: retry CI (container init was failing)
davdhacs Mar 30, 2026
bd2b70d
empty: timing data point 2
davdhacs Mar 30, 2026
d941366
empty: timing data point 3
davdhacs Mar 30, 2026
20b1014
empty: timing data point 6
davdhacs Mar 31, 2026
7544f30
Merge origin/master into davdhacs/skip-gomodcache
davdhacs Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .github/actions/cache-go-dependencies/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,31 +16,12 @@ runs:
id: cache-paths
run: |
echo "GOCACHE=$(go env GOCACHE)" >> "$GITHUB_OUTPUT"
echo "GOMODCACHE=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT"
echo "GOARCH=$(go env GOARCH)" >> "$GITHUB_OUTPUT"
echo "TAG=${{ github.sha }}" >> "$GITHUB_OUTPUT"
suffix="${{ inputs.key-suffix }}"
echo "KEY_SUFFIX=${suffix:+-$suffix}" >> "$GITHUB_OUTPUT" # prepends dash if set
shell: bash

# Save caches only on pushes to the default branch.
# All other events (PRs, etc.) restore only.
- name: Cache Go Dependencies (save)
if: inputs.save == 'true' && (github.event_name == 'push' && github.ref_name == github.event.repository.default_branch)
uses: actions/cache@v5
with:
path: ${{ steps.cache-paths.outputs.GOMODCACHE }}
key: go-mod-v1-${{ hashFiles('**/go.sum') }}
restore-keys: go-mod-v1-

- name: Cache Go Dependencies (restore)
if: ${{ !(inputs.save == 'true' && (github.event_name == 'push' && github.ref_name == github.event.repository.default_branch)) }}
uses: actions/cache/restore@v5
with:
path: ${{ steps.cache-paths.outputs.GOMODCACHE }}
key: go-mod-v1-${{ hashFiles('**/go.sum') }}
restore-keys: go-mod-v1-

- name: Cache Go Build (save)
if: inputs.save == 'true' && (github.event_name == 'push' && github.ref_name == github.event.repository.default_branch)
uses: actions/cache@v5
Expand Down Expand Up @@ -90,7 +71,3 @@ runs:
find "$gocache" -mindepth 1 -type d -empty -delete 2>/dev/null || true;
after=$(du -sm "$gocache" 2>/dev/null | cut -f1);
echo "GOCACHE trimmed: ${before:-0}MB -> ${after:-0}MB (removed $((${before:-0} - ${after:-0}))MB)"

- name: Download Go modules
run: make deps --always-make
shell: bash
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ jobs:
- name: Cache Go dependencies
uses: ./.github/actions/cache-go-dependencies

- name: Resolve mods for protos
run: go mod tidy
- name: Download scanner module for proto generation
run: go mod download github.com/stackrox/scanner

- name: Generate the swagger docs
run: |
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/style.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ jobs:
- name: Cache Go dependencies
uses: ./.github/actions/cache-go-dependencies

- name: Download scanner module for proto generation
run: go mod download github.com/stackrox/scanner

- name: Check Generated
run: scripts/ci/jobs/check-generated.sh

Expand Down Expand Up @@ -156,6 +159,9 @@ jobs:
- name: Cache Go dependencies
uses: ./.github/actions/cache-go-dependencies

- name: Download scanner module for proto generation
run: go mod download github.com/stackrox/scanner

- name: Cache UI dependencies
uses: ./.github/actions/cache-ui-dependencies

Expand Down
Loading