Skip to content

ROX-33330: Proto for targeted image cache invalidation in adm ctrl#19597

Merged
clickboo merged 1 commit intomasterfrom
boo-adm-cntrl-targeted-invalidation-foundation
Apr 1, 2026
Merged

ROX-33330: Proto for targeted image cache invalidation in adm ctrl#19597
clickboo merged 1 commit intomasterfrom
boo-adm-cntrl-targeted-invalidation-foundation

Conversation

@clickboo
Copy link
Copy Markdown
Contributor

@clickboo clickboo commented Mar 25, 2026 •
edited
Loading

Description

This is a foundational, proto only PR for implementing targeted image cache invalidation for admission controller.

Today, we purge admission controller image cache pretty aggressively. Optimal cache warmth is essential to reduce image fetch/scan calls and hence improve admission controller throughput and burst resilience at scale.

This PR introduces the protobuf messages which will be used by sensor in the future to invalidate only certain image cache keys.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI only given protobuf changes only.

@clickboo
Copy link
Copy Markdown
Contributor Author

clickboo commented Mar 25, 2026 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

sourcery-ai[bot]

This comment was marked as outdated.

Sign in to view

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 25, 2026 •
edited
Loading

Images are ready for the commit at 782897c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-526-g782897c7df.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.59%. Comparing base (c3cccf6) to head (782897c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19597   +/-   ##
=======================================
  Coverage   49.59%   49.59%           
=======================================
  Files        2756     2756           
  Lines      208036   208036           
=======================================
  Hits       103183   103183           
  Misses      97192    97192           
  Partials     7661     7661
Flag Coverage Δ
go-unit-tests 49.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clickboo clickboo force-pushed the boo-adm-cntrl-targeted-invalidation-foundation branch from 8d1867f to 4031ed6 Compare March 25, 2026 10:48
@clickboo clickboo changed the title ROX-33328,ROX-33330: Generation counters, foundation for targeted cache invalidation ROX-33330: Proto for targeted image invalidation in admission controller Mar 25, 2026
@clickboo clickboo changed the title ROX-33330: Proto for targeted image invalidation in admission controller ROX-33330: Proto for targeted image cache invalidation in adm ctrl Mar 25, 2026
@clickboo clickboo mentioned this pull request Mar 25, 2026
Open
9 tasks
@clickboo
Copy link
Copy Markdown
Contributor Author

clickboo commented Mar 25, 2026

/test all

@clickboo clickboo force-pushed the boo-adm-cntrl-targeted-invalidation-foundation branch from 4031ed6 to 348220e Compare March 25, 2026 15:00
@clickboo clickboo requested a review from a team March 25, 2026 15:00
@clickboo clickboo marked this pull request as ready for review March 25, 2026 15:07
@clickboo clickboo requested a review from a team as a code owner March 25, 2026 15:07
sourcery-ai[bot]
sourcery-ai bot reviewed Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

parametalol
parametalol approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@parametalol parametalol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clickboo
Copy link
Copy Markdown
Contributor Author

clickboo commented Mar 25, 2026

/test gke-ui-e2e-tests

@clickboo clickboo force-pushed the boo-adm-cntrl-targeted-invalidation-foundation branch 2 times, most recently from ec0f7f7 to 1ad1e5f Compare March 31, 2026 08:56
This was referenced Mar 31, 2026
Merged
Closed
@clickboo clickboo force-pushed the boo-adm-cntrl-targeted-invalidation-foundation branch from 1ad1e5f to 782897c Compare April 1, 2026 18:35
@clickboo
Copy link
Copy Markdown
Contributor Author

clickboo commented Apr 1, 2026

/test all

@clickboo clickboo merged commit 73cac11 into master Apr 1, 2026
192 of 223 checks passed
@clickboo clickboo deleted the boo-adm-cntrl-targeted-invalidation-foundation branch April 1, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@parametalol parametalol parametalol approved these changes

Assignees

No one assigned

Labels

ai-review area/admission-controller area/sensor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clickboo @rhacs-bot @parametalol