Skip to content

chore(be): Add a cache skip metric counter for admission controller#19426

Merged
clickboo merged 1 commit intomasterfrom
boo-adm-ctrl-cache-skip-metric
Mar 17, 2026
Merged

chore(be): Add a cache skip metric counter for admission controller#19426
clickboo merged 1 commit intomasterfrom
boo-adm-ctrl-cache-skip-metric

Conversation

@clickboo
Copy link
Copy Markdown
Contributor

@clickboo clickboo commented Mar 15, 2026 •
edited
Loading

Description

See title

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI only.

@clickboo
Copy link
Copy Markdown
Contributor Author

clickboo commented Mar 15, 2026 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@stackrox stackrox deleted a comment from openshift-ci bot Mar 15, 2026
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 15, 2026 •
edited
Loading

Images are ready for the commit at 98055ee.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-344-g98055ee79f.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.37%. Comparing base (2654a0e) to head (98055ee).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19426      +/-   ##
==========================================
- Coverage   49.37%   49.37%   -0.01%     
==========================================
  Files        2713     2713              
  Lines      204977   204980       +3     
==========================================
- Hits       101207   101206       -1     
- Misses      96242    96244       +2     
- Partials     7528     7530       +2
Flag Coverage Δ
go-unit-tests 49.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stackrox stackrox deleted a comment from openshift-ci bot Mar 15, 2026
@clickboo clickboo force-pushed the boo-adm-ctrl-fast-detection branch from ca4a999 to c0f8ba2 Compare March 15, 2026 13:30
@clickboo clickboo force-pushed the boo-adm-ctrl-cache-skip-metric branch from 1c28af7 to 2be89e1 Compare March 15, 2026 13:33
@clickboo clickboo marked this pull request as ready for review March 15, 2026 13:44
@clickboo clickboo requested a review from a team as a code owner March 15, 2026 13:44
sourcery-ai[bot]
sourcery-ai bot reviewed Mar 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@clickboo clickboo mentioned this pull request Mar 16, 2026
Draft
@clickboo clickboo requested a review from vikin91 March 16, 2026 05:21
@clickboo clickboo force-pushed the boo-adm-ctrl-fast-detection branch from c0f8ba2 to 64b551e Compare March 16, 2026 05:22
@clickboo clickboo requested a review from a team as a code owner March 16, 2026 05:22
@clickboo clickboo force-pushed the boo-adm-ctrl-cache-skip-metric branch from 2be89e1 to 8cb4b89 Compare March 16, 2026 05:23
@clickboo clickboo force-pushed the boo-adm-ctrl-fast-detection branch from 64b551e to aa495d1 Compare March 16, 2026 06:28
@clickboo clickboo force-pushed the boo-adm-ctrl-cache-skip-metric branch from 8cb4b89 to a5f65af Compare March 16, 2026 06:44
@clickboo
Copy link
Copy Markdown
Contributor Author

clickboo commented Mar 16, 2026

/test all

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 16, 2026

@clickboo: No presubmit jobs available for stackrox/stackrox@boo-adm-ctrl-fast-detection

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@clickboo clickboo force-pushed the boo-adm-ctrl-fast-detection branch from aa495d1 to 8db5f38 Compare March 16, 2026 09:00
@clickboo clickboo force-pushed the boo-adm-ctrl-cache-skip-metric branch from a5f65af to 0531859 Compare March 16, 2026 09:00
@clickboo clickboo mentioned this pull request Mar 16, 2026
Merged
9 tasks
vikin91
vikin91 approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from boo-adm-ctrl-fast-detection to master March 17, 2026 11:18
@clickboo clickboo force-pushed the boo-adm-ctrl-cache-skip-metric branch from 0531859 to 98055ee Compare March 17, 2026 11:31
@clickboo
Copy link
Copy Markdown
Contributor Author

clickboo commented Mar 17, 2026

/test all

@stackrox stackrox deleted a comment from openshift-ci bot Mar 17, 2026
@clickboo clickboo merged commit f6e2411 into master Mar 17, 2026
162 of 185 checks passed
@clickboo clickboo deleted the boo-adm-ctrl-cache-skip-metric branch March 17, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@vikin91 vikin91 vikin91 approved these changes

Assignees

No one assigned

Labels

ai-review area/admission-controller area/sensor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clickboo @rhacs-bot @vikin91