Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
|
Images are ready for the commit at c22c6cb. To use with deploy scripts, first |
stehessel
approved these changes
Mar 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19414 +/- ##
=======================================
Coverage 49.70% 49.71%
=======================================
Files 2701 2701
Lines 203453 203453
=======================================
+ Hits 101134 101138 +4
+ Misses 94790 94787 -3
+ Partials 7529 7528 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
parametalol
reviewed
Mar 13, 2026
Previous refactoring changed deployments from List to Map but missed updating iteration and property access, causing test failures: - GroovyCastException: iterating Map yields Map.Entry, not Deployment - NullPointerException: Maps don't have .name property Fixes: - Use deployments.values() for iteration in destroyDeployments() - Use deployments.keySet().join() for query string construction - Add type annotations to modified lines (String, boolean) User request: Fix test failures, keep diff minimal, add types only to changed lines Partially AI-assisted.
janisz
force-pushed
the
cleanup_network_flow_test
branch
from
d3ee8bc to
aefbfb4
Compare
janisz
changed the title
The spread operator on a Map iterates over Map.Entry objects, not values. Changed deployments*.namespace to deployments.values()*.namespace to fix MissingPropertyException. Partially AI-assisted.
janisz
added a commit
that referenced
this pull request
Apr 7, 2026
Replace List<Deployment> with Map<String, Deployment> in test files to eliminate O(n) linear searches when looking up deployments by name. Changed files use the pattern from PR #19414 (NetworkFlowTest): - Direct map access: DEPLOYMENTS[name] instead of .find { it.name == name } - Iteration: DEPLOYMENTS.values() for loops - Conversion: .collectEntries { [(it.name): it] } K8sEventDetectionTest required special handling due to dynamic registration pattern (empty map initialization and map assignment). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
janisz
added a commit
that referenced
this pull request
Apr 7, 2026
Replace List<Deployment> with Map<String, Deployment> in 4 more test files to eliminate O(n) linear searches when looking up deployments by name. Files updated: - ProcessBaselinesTest.groovy (7 .find usages → map access) - ProcessesListeningOnPortsTest.groovy (6 .find usages → map access) - DefaultPoliciesTest.groovy (1 .find usage → map access) - VulnScanWithGraphQLTest.groovy (1 .find usage → map access) Changes follow the pattern from PR #19414 (NetworkFlowTest): - Direct map access: DEPLOYMENTS[name] or targetDeployments[name] - Iteration: .values() for loops - Conversion: .collectEntries { [(it.name): it] } ProcessBaselinesTest required special handling as DEPLOYMENTS is created via .collect transformation before the .collectEntries conversion. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change deployments from list to map to allow direct access instead of
findUser-facing documentation
Testing and quality
Automated testing
How I validated my change
CI