ROX-33574: Don't forget to configure scanner pull secrets#19383
Merged
mclasmeier merged 1 commit intomasterfrom Mar 16, 2026
Merged
ROX-33574: Don't forget to configure scanner pull secrets#19383mclasmeier merged 1 commit intomasterfrom
mclasmeier merged 1 commit intomasterfrom
Conversation
mclasmeier
changed the title
mclasmeier
changed the title
Contributor
|
Images are ready for the commit at 985d901. To use with deploy scripts, first |
mclasmeier
force-pushed
the
mc/helm-scanner-pull-secrets
branch
from
fac2083 to
b94ce02
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 28322140 | Triggered | Username Password | 985d901 | pkg/helm/charts/tests/securedclusterservices/testdata/helmtest/image-pull-secrets.test.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
when scanner V4 is disabled and only scanner V2 is being used.
mclasmeier
force-pushed
the
mc/helm-scanner-pull-secrets
branch
from
b94ce02 to
985d901
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19383 +/- ##
=======================================
Coverage 49.65% 49.65%
=======================================
Files 2698 2698
Lines 203120 203132 +12
=======================================
+ Hits 100852 100864 +12
- Misses 94745 94746 +1
+ Partials 7523 7522 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
porridge
approved these changes
Mar 16, 2026
mclasmeier
added
backport release-4.8
backport release-4.9
rhacs-bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
rhacs-bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
This was referenced Mar 17, 2026
rhacs-bot
pushed a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ROX-33574. Fixes a bug in the secured-cluster Helm chart.
User-facing documentation
This is a bug fix, don't need a CHANGELOG entry for this.
Testing and quality
Automated testing
How I validated my change
change me!