Skip to content

chore(operator): simplify deploy-via-chart#19288

Merged
rhacs-bot merged 1 commit intomasterfrom
porridge/ROX-33115-test-chart-wait
Mar 5, 2026
Merged

chore(operator): simplify deploy-via-chart#19288
rhacs-bot merged 1 commit intomasterfrom
porridge/ROX-33115-test-chart-wait

Conversation

@porridge
Copy link
Copy Markdown
Contributor

@porridge porridge commented Mar 4, 2026 •
edited
Loading

Description

Now that dependabot config is fixed in #19264 and #19268 bumped to new release that adds envOverrides support, we can simplify this into a single command.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

CI is enough.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 4, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@porridge
Copy link
Copy Markdown
Contributor Author

porridge commented Mar 4, 2026

/test gke-operator-e2e-tests

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 4, 2026 •
edited
Loading

Images are ready for the commit at 33f134a.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-238-g33f134a879.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.62%. Comparing base (38dc769) to head (33f134a).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19288   +/-   ##
=======================================
  Coverage   49.62%   49.62%           
=======================================
  Files        2680     2680           
  Lines      202214   202214           
=======================================
+ Hits       100341   100347    +6     
+ Misses      94394    94391    -3     
+ Partials     7479     7476    -3
Flag Coverage Δ
go-unit-tests 49.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GrimmiMeloni GrimmiMeloni requested a review from mclasmeier March 4, 2026 10:58
@porridge porridge force-pushed the porridge/ROX-33115-test-chart-wait branch from 763c73c to 0cedcfe Compare March 4, 2026 10:59
@porridge
Copy link
Copy Markdown
Contributor Author

porridge commented Mar 4, 2026

/test gke-operator-e2e-tests

@porridge
Copy link
Copy Markdown
Contributor Author

porridge commented Mar 4, 2026

image

Why @GrimmiMeloni ? It's not ready for review yet.

@porridge porridge force-pushed the porridge/ROX-33115-test-chart-wait branch from 0cedcfe to 33f134a Compare March 4, 2026 13:04
@porridge
Copy link
Copy Markdown
Contributor Author

porridge commented Mar 4, 2026

/test gke-operator-e2e-tests

@GrimmiMeloni
Copy link
Copy Markdown
Contributor

GrimmiMeloni commented Mar 4, 2026

Why @GrimmiMeloni ? It's not ready for review yet.

JIRA showed it as part of ROX-33115 - hence I assinged both PRs to Moritz for review. 🤷

@porridge porridge marked this pull request as ready for review March 5, 2026 05:38
@porridge porridge requested a review from a team as a code owner March 5, 2026 05:38
@porridge
Copy link
Copy Markdown
Contributor Author

porridge commented Mar 5, 2026

Now ready for review, @mclasmeier

mclasmeier
mclasmeier reviewed Mar 5, 2026
View reviewed changes
mclasmeier
mclasmeier approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mclasmeier mclasmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@porridge porridge added auto-merge Auto-merge minor and patch version bumps auto-retest PRs with this label will be automatically retested if prow checks fails labels Mar 5, 2026
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 5, 2026

/retest

@rhacs-bot rhacs-bot merged commit 1c8578d into master Mar 5, 2026
110 checks passed
@rhacs-bot rhacs-bot deleted the porridge/ROX-33115-test-chart-wait branch March 5, 2026 12:22
ksurabhi91 pushed a commit that referenced this pull request Mar 12, 2026
@porridge @ksurabhi91
chore(operator): simplify deploy-via-chart (#19288)
59d2e41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mclasmeier mclasmeier mclasmeier approved these changes

Assignees

No one assigned

Labels

area/operator auto-merge Auto-merge minor and patch version bumps auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@porridge @rhacs-bot @GrimmiMeloni @mclasmeier