Merged
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The inline comments with precise cache sizes (e.g.,
~2,000 MB) are likely to drift over time; consider either removing the size details or replacing them with a more durable explanation (e.g., that saving caches here interferes with generated file checks) so the rationale stays accurate. - You now repeat
with: save: falseforcache-go-dependenciesin several jobs; if this is intended to be the default behavior, consider moving thesave: falselogic into the composite action itself (or using YAML anchors) to avoid duplication and ensure future jobs inherit the same behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The inline comments with precise cache sizes (e.g., `~2,000 MB`) are likely to drift over time; consider either removing the size details or replacing them with a more durable explanation (e.g., that saving caches here interferes with generated file checks) so the rationale stays accurate.
- You now repeat `with: save: false` for `cache-go-dependencies` in several jobs; if this is intended to be the default behavior, consider moving the `save: false` logic into the composite action itself (or using YAML anchors) to avoid duplication and ensure future jobs inherit the same behavior.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
tommartensen
approved these changes
Feb 19, 2026
Contributor
|
Images are ready for the commit at a748e42. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19108 +/- ##
==========================================
- Coverage 49.52% 49.52% -0.01%
==========================================
Files 2672 2672
Lines 201665 201665
==========================================
- Hits 99874 99870 -4
- Misses 94333 94336 +3
- Partials 7458 7459 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davdhacs
added a commit
that referenced
this pull request
Feb 19, 2026
…files PR #19069 removed all save: false, but check-generated-files modifies the working tree (regenerates protos, removes mocks) which breaks hashFiles('**/go.sum') in the GOMODCACHE post-step, causing cache save failures. Reverted in #19108. Re-enable saves for all other jobs (unit-tests, style-check, scanner-db-integration-tests) while keeping save: false only for check-generated-files where the hashFiles failure occurs. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #19069 as it broke generated files checks on master.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!