Skip to content

ROX-30588: Update claircore#18710

Closed
BradLugo wants to merge 1 commit intomasterfrom
blugo/ROX-30588-update-claircore
Closed

ROX-30588: Update claircore#18710
BradLugo wants to merge 1 commit intomasterfrom
blugo/ROX-30588-update-claircore

Conversation

@BradLugo
Copy link
Copy Markdown
Contributor

@BradLugo BradLugo commented Jan 27, 2026 •
edited
Loading

Description

Updates claircore to a version that implements the SPDX SBOM decoding API.

Requires a claircore tag containing quay/claircore#1746.

PR stack:

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

N/A

How I validated my change

CI should be sufficient.

@BradLugo BradLugo requested review from a team as code owners January 27, 2026 23:07
@BradLugo BradLugo force-pushed the blugo/ROX-32846-GetRepositoryToCPEMapping branch from 1d03f53 to 3a3b390 Compare January 27, 2026 23:09
@dcaravel
Copy link
Copy Markdown
Contributor

dcaravel commented Jan 28, 2026

@BradLugo would you like this one reviewed? See it points claircore to your fork.

@BradLugo
Copy link
Copy Markdown
Contributor Author

BradLugo commented Jan 28, 2026

I suppose this should be a draft until we have a claircore tag containing quay/claircore#1745.

@BradLugo BradLugo added the ci-all-qa-tests Tells CI to run all API tests (not just BAT). label Jan 28, 2026
@BradLugo BradLugo marked this pull request as draft January 28, 2026 05:51
@BradLugo BradLugo force-pushed the blugo/ROX-30588-update-claircore branch from 1e8c517 to dfad150 Compare January 28, 2026 05:52
@BradLugo BradLugo force-pushed the blugo/ROX-32846-GetRepositoryToCPEMapping branch from 3a3b390 to 9bff2aa Compare January 28, 2026 05:52
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Jan 28, 2026 •
edited
Loading

Images are ready for the commit at 6a38701.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-881-g6a387010a9.

This was referenced Jan 28, 2026
Draft
Draft
@BradLugo BradLugo changed the title ROX-30588: update claircore ROX-30588: Update claircore Jan 28, 2026
@BradLugo BradLugo force-pushed the blugo/ROX-30588-update-claircore branch 2 times, most recently from a394359 to 6a38701 Compare January 28, 2026 16:30
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.16%. Comparing base (9bff2aa) to head (6a38701).

Files with missing lines Patch % Lines
compliance/node/index/indexer.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                              Coverage Diff                              @@
##           blugo/ROX-32846-GetRepositoryToCPEMapping   #18710      +/-   ##
=============================================================================
- Coverage                                      49.16%   49.16%   -0.01%     
=============================================================================
  Files                                           2661     2661              
  Lines                                         200014   200021       +7     
=============================================================================
- Hits                                           98345    98338       -7     
- Misses                                         94238    94249      +11     
- Partials                                        7431     7434       +3
Flag Coverage Δ
go-unit-tests 49.16% <78.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BradLugo BradLugo force-pushed the blugo/ROX-30588-update-claircore branch from 6a38701 to 68728a0 Compare March 16, 2026 19:39
@BradLugo BradLugo changed the base branch from blugo/ROX-32846-GetRepositoryToCPEMapping to master March 16, 2026 19:42
@BradLugo BradLugo marked this pull request as ready for review March 16, 2026 21:35
@BradLugo BradLugo requested a review from a team March 16, 2026 21:36
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 17, 2026

@BradLugo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-upgrade-tests 68728a0 link false /test gke-upgrade-tests
ci/prow/gke-qa-e2e-tests 68728a0 link false /test gke-qa-e2e-tests
ci/prow/gke-nongroovy-e2e-tests 68728a0 link true /test gke-nongroovy-e2e-tests
ci/prow/gke-ui-e2e-tests 68728a0 link true /test gke-ui-e2e-tests
ci/prow/ocp-4-12-compliance-e2e-tests 68728a0 link false /test ocp-4-12-compliance-e2e-tests
ci/prow/ocp-4-20-nongroovy-e2e-tests 68728a0 link false /test ocp-4-20-nongroovy-e2e-tests
ci/prow/ocp-4-20-compliance-e2e-tests 68728a0 link false /test ocp-4-20-compliance-e2e-tests
ci/prow/ocp-4-21-compliance-e2e-tests 68728a0 link false /test ocp-4-21-compliance-e2e-tests
ci/prow/ocp-4-21-nongroovy-e2e-tests 68728a0 link false /test ocp-4-21-nongroovy-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests 68728a0 link false /test ocp-4-12-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vikin91
Copy link
Copy Markdown
Contributor

vikin91 commented Mar 20, 2026 •
edited
Loading

Please see also: #19422

Also check the PR description as I noticed node/VM indexing performance degradation.

@BradLugo
Copy link
Copy Markdown
Contributor Author

BradLugo commented Mar 20, 2026

Closing in favor of #19422.

@BradLugo BradLugo closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/scanner ci-all-qa-tests Tells CI to run all API tests (not just BAT).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BradLugo @dcaravel @rhacs-bot @vikin91