Skip to content

WIP: E2E test for VM that checks policy and risk#184

Closed
theencee wants to merge 2 commits into
masterfrom
nc/e2e-vm-policy-risk
Closed

WIP: E2E test for VM that checks policy and risk#184
theencee wants to merge 2 commits into
masterfrom
nc/e2e-vm-policy-risk

Conversation

@theencee

@theencee theencee commented Dec 21, 2021

Copy link
Copy Markdown
Contributor

Description

A detailed explanation of the changes in your PR.

Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@ghost

ghost commented Dec 21, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

Tag for build #204253 is 3.68.x-189-gb80cf4cba2.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.68.x-189-gb80cf4cba2'

📦 You can also generate an installation bundle with:

docker run -i --rm stackrox/main:3.68.x-189-gb80cf4cba2 central generate interactive > bundle.zip

🕹️ A roxctl binary artifact can be downloaded from CircleCI.

@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 7 times, most recently from 931a86e to 598f2c6 Compare December 23, 2021 09:23
md2119
md2119 reviewed Dec 23, 2021
View reviewed changes
Comment thread qa-tests-backend/src/test/groovy/VulnMgmtWorkflowTest.groovy Outdated

@md2119 md2119 Dec 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert here to see if the approval went thru

@theencee theencee Jan 7, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary. The test above checks it already and it's implicitly checked because otherwise the policy would be triggered.

md2119
md2119 reviewed Dec 23, 2021
View reviewed changes
Comment thread qa-tests-backend/src/test/groovy/VulnMgmtWorkflowTest.groovy Outdated

@md2119 md2119 Dec 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this matching the namespace in which the deployment is being created?

@md2119 md2119 Dec 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the deployment is created in default namespace, but the policy is scoped to qa namespace.

@theencee theencee Dec 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets created in qa by default which is what that const evaluates to:

$ kubectl get pods -n=qa -w
NAME                                 READY   STATUS    RESTARTS   AGE
vulnerable-deploy-58ff9487b6-84llt   1/1     Running   0          65s

@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch from 598f2c6 to 79ee0b4 Compare January 4, 2022 18:22
md2119
md2119 reviewed Jan 4, 2022
View reviewed changes
Comment thread qa-tests-backend/src/test/groovy/VulnMgmtWorkflowTest.groovy Outdated
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 6 times, most recently from f3c103e to 5b2390f Compare January 8, 2022 00:50
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 2 times, most recently from 6da86e1 to b1690dc Compare January 10, 2022 22:17
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 2 times, most recently from 25542b3 to 5ac3808 Compare January 10, 2022 23:50
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 5 times, most recently from 8fdd7f3 to b40a833 Compare January 11, 2022 21:25
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch from 4585e03 to 1f6ec50 Compare January 13, 2022 17:30
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 11 times, most recently from 7455c5b to 30e6cd3 Compare January 17, 2022 08:47
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 2 times, most recently from 5a21eb1 to be7cf75 Compare January 19, 2022 04:53
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch from be7cf75 to 2b6f0ce Compare February 1, 2022 21:36
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch 2 times, most recently from a67b940 to 2f72b39 Compare February 10, 2022 22:06
@theencee theencee force-pushed the nc/e2e-vm-policy-risk branch from 2f72b39 to b80cf4c Compare February 10, 2022 23:08
@openshift-ci

openshift-ci Bot commented May 8, 2022

Copy link
Copy Markdown

@theencee: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Dec 12, 2023

Copy link
Copy Markdown

@theencee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-upgrade-tests b80cf4c link true /test gke-upgrade-tests
ci/prow/stackrox_branding-images b80cf4c link true /test stackrox_branding-images
ci/prow/ui-unit-tests b80cf4c link true /test ui-unit-tests
ci/prow/integration-unit-tests b80cf4c link true /test integration-unit-tests
ci/prow/go-unit-tests b80cf4c link true /test go-unit-tests
ci/prow/go-unit-tests-release b80cf4c link true /test go-unit-tests-release
ci/prow/policy-checks b80cf4c link true /test policy-checks
ci/prow/mitre-bundles-checks b80cf4c link true /test mitre-bundles-checks
ci/prow/go-postgres-tests b80cf4c link true /test go-postgres-tests
ci/prow/grouped-static-checks b80cf4c link true /test grouped-static-checks
ci/prow/shell-unit-tests b80cf4c link true /test shell-unit-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vjwilson vjwilson closed this Sep 16, 2025
@vjwilson vjwilson deleted the nc/e2e-vm-policy-risk branch September 16, 2025 18:14
@davdhacs davdhacs mentioned this pull request Jun 5, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz Awaiting requested review from janisz janisz will be requested when the pull request is marked ready for review janisz is a code owner

1 more reviewer

@md2119 md2119 md2119 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/central area/sensor needs-rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theencee @md2119 @vjwilson @gavin-stackrox