-
Notifications
You must be signed in to change notification settings - Fork 174
ROX-32316: Add central rate limiter for VM index reports #18220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d8063f6
Empty commit
vikin91 49a294d
ROX-32316: Add generic rate limiter for VM index reports
vikin91 d9586df
Readd rate limiting env vars
vikin91 1bcad9c
Use HasCapability as in the other pipelines
vikin91 e4d8949
Inject clock to rate limiter to avoid test flakiness
vikin91 8ac9222
Fix style: use the correct sync pkg
vikin91 66cca03
Fix: Skip sending on nil injector
vikin91 2eddfa5
Make rate limiter more generic
vikin91 7c47644
Improve metrics coverage
vikin91 1a4024f
Improve logs
vikin91 926eac1
Add defensive checks for rate limiter
vikin91 72effbb
Rephrase log message
vikin91 0cd7004
Fix race in getOrCreateLimiter
vikin91 fda13c6
Add debug log
vikin91 0b6dcf3
Change default ROX_VM_INDEX_REPORT_RATE_LIMIT to 1.0
vikin91 e8eab5f
Add comment on default rate limiter setting
vikin91 205ab76
Record metrics in rate-unlimited mode
vikin91 7b95652
Remove metrics: RequestsAccepted, RequestsRejected
vikin91 e9f7e19
Remove rate-limiter registry
vikin91 6933634
Add test coverage
vikin91 eda61fb
More limiter tests. Modify log statements
vikin91 2339b91
Drop sync.Map in favor of map+RWmutex (benchmarked)
vikin91 b3dc279
Address review: logging & test coverage
vikin91 90dd180
Change default rate limit for VM to 0.3
vikin91 1bbd36e
Add comment to pkg limiter
vikin91 0a344e1
Rephrase comment and reason string for nil rate limiter
vikin91 0136d77
Use rate-limited logger if the workload rate-limiter is nil
vikin91 34057eb
Update also test expectation for the changed reason string
vikin91 b99627d
Update comment to the rate limit env setting
vikin91 ab9279e
Change the fallback-default rate-limit to 0.3
vikin91 776693a
Remove the additional validation for ROX_VM_INDEX_REPORT_BUCKET_CAPACITY
vikin91 b2bcd0d
Use error instead of warning. Fix log text 1.0->0.3
vikin91 149a807
Mladen: Don't panic if cannot create rate limiter
vikin91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.