Skip to content

ROX-31321: do not write component score to risk #17422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dashrews78 merged 3 commits into from
Nov 13, 2025
Merged

ROX-31321: do not write component score to risk #17422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21bf5ee
X-Smart-Branch-Parent: master
dashrews78 Oct 21, 2025
5a94e93
do not write data we will never use
dashrews78 Oct 21, 2025
d4306ca
adjust unit test
dashrews78 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions central/risk/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,18 +357,6 @@ func (e *managerImpl) reprocessImageComponentRisk(imageComponent *storage.Embedd
return
}

oldScore := e.imageComponentRanker.GetScoreForID(
scancomponent.ComponentIDV2(imageComponent, imageID, componentIndex))

// Image component risk results are currently unused so if the score is the same then no need to upsert
if risk.GetScore() == oldScore {
return
}

if err := e.riskStorage.UpsertRisk(riskReprocessorCtx, risk); err != nil {
log.Errorf("Error reprocessing risk for image component %s %s: %v", imageComponent.GetName(), imageComponent.GetVersion(), err)
}

imageComponent.RiskScore = risk.GetScore()
// skip direct upsert here since it is handled during image upsert
}
Expand All @@ -383,18 +371,6 @@ func (e *managerImpl) reprocessNodeComponentRisk(nodeComponent *storage.Embedded
return
}

oldScore := e.nodeComponentRanker.GetScoreForID(
scancomponent.ComponentID(nodeComponent.GetName(), nodeComponent.GetVersion(), os))

// Node component risk results are not currently used so if the score is the same then no need to upsert
if risk.GetScore() == oldScore {
return
}

if err := e.riskStorage.UpsertRisk(riskReprocessorCtx, risk); err != nil {
log.Errorf("Error reprocessing risk for node component %s %s: %v", nodeComponent.GetName(), nodeComponent.GetVersion(), err)
}

nodeComponent.RiskScore = risk.GetScore()
// skip direct upsert here since it is handled during node upsert
}
Expand Down
2 changes: 1 addition & 1 deletion central/sensor/service/pipeline/nodeinventory/two_pipelines_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func Test_TwoPipelines_Run(t *testing.T) {
// node arrives
m.clusterStore.EXPECT().GetClusterName(gomock.Any(), gomock.Eq(clusterID)).Return(clusterID, true, nil),
m.cveDatastore.EXPECT().EnrichNodeWithSuppressedCVEs(gomock.Any()),
m.riskStorage.EXPECT().UpsertRisk(gomock.Any(), gomock.Any()).Times(2).Return(nil),
m.riskStorage.EXPECT().UpsertRisk(gomock.Any(), gomock.Any()).Times(1).Return(nil),
m.nodeDatastore.EXPECT().UpsertNode(gomock.Any(), gomock.Any()).Return(nil),

// check what got stored in the DB
Expand Down
Loading