Skip to content

chore(bench): image upsert benchmark #17274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dashrews78 merged 4 commits into from
Oct 14, 2025
Merged

chore(bench): image upsert benchmark #17274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b85ca9
X-Smart-Branch-Parent: master
dashrews78 Oct 14, 2025
30a5959
add bench for upsert
dashrews78 Oct 14, 2025
d7c424c
add bench for imagesv2
dashrews78 Oct 14, 2025
4ebac98
make closer to real IDs
dashrews78 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions central/image/datastore/datastore_bench_postgres_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ package datastore

import (
"context"
"crypto/rand"
"crypto/sha256"
"fmt"
"testing"

Expand Down Expand Up @@ -65,3 +67,40 @@ func BenchmarkImageGetMany(b *testing.B) {
}
})
}

func BenchmarkImageUpsert(b *testing.B) {
ctx := sac.WithAllAccess(context.Background())

testDB := pgtest.ForT(b)

gormDB := testDB.GetGormDB(b)
db := testDB.DB

mockRisk := mockRisks.NewMockDataStore(gomock.NewController(b))
var datastore DataStore
if features.FlattenCVEData.Enabled() {
datastore = NewWithPostgres(pgStoreV2.New(db, false, keyfence.ImageKeyFenceSingleton()), mockRisk, ranking.NewRanker(), ranking.NewRanker())
} else {
datastore = NewWithPostgres(pgStore.CreateTableAndNewStore(ctx, db, gormDB, false), mockRisk, ranking.NewRanker(), ranking.NewRanker())
}

images := make([]*storage.Image, 0, 100)
for i := 0; i < 100; i++ {
img := fixtures.GetImageWithUniqueComponents(50)
data := make([]byte, 10)
if _, err := rand.Read(data); err == nil {
id := fmt.Sprintf("%x", sha256.Sum256(data))
require.NoError(b, err)
img.Id = id
}
images = append(images, img)
}

b.Run("UpsertImage", func(b *testing.B) {
for i := 0; i < b.N; i++ {
for _, img := range images {
require.NoError(b, datastore.UpsertImage(ctx, img))
}
}
})
}
93 changes: 93 additions & 0 deletions central/imagev2/datastore/datastore_bench_postgres_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
//go:build sql_integration

package datastore

import (
"context"
"fmt"
"testing"

"github.com/stackrox/rox/central/image/datastore/keyfence"
pgStore "github.com/stackrox/rox/central/imagev2/datastore/store/postgres"
"github.com/stackrox/rox/central/ranking"
mockRisks "github.com/stackrox/rox/central/risk/datastore/mocks"
"github.com/stackrox/rox/generated/storage"
"github.com/stackrox/rox/pkg/features"
"github.com/stackrox/rox/pkg/fixtures"
"github.com/stackrox/rox/pkg/postgres/pgtest"
"github.com/stackrox/rox/pkg/sac"
"github.com/stackrox/rox/pkg/uuid"
"github.com/stretchr/testify/require"
"go.uber.org/mock/gomock"
)

func BenchmarkImageGetMany(b *testing.B) {
if !features.FlattenImageData.Enabled() {
b.Skip("Image flattened data model is not enabled")
}
ctx := sac.WithAllAccess(context.Background())

testDB := pgtest.ForT(b)

db := testDB.DB

mockRisk := mockRisks.NewMockDataStore(gomock.NewController(b))
datastore := NewWithPostgres(pgStore.New(db, false, keyfence.ImageKeyFenceSingleton()), mockRisk, ranking.NewRanker(), ranking.NewRanker())

ids := make([]string, 0, 100)
images := make([]*storage.ImageV2, 0, 100)
for i := 0; i < 100; i++ {
img := fixtures.GetImageV2WithUniqueComponents(5)
id := fmt.Sprintf("%d", i)
ids = append(ids, id)
img.Id = id
images = append(images, img)
}

for _, image := range images {
require.NoError(b, datastore.UpsertImage(ctx, image))
}

b.Run("GetImagesBatch", func(b *testing.B) {
for i := 0; i < b.N; i++ {
_, err := datastore.GetImagesBatch(ctx, ids)
require.NoError(b, err)
}
})

b.Run("GetManyImageMetadata", func(b *testing.B) {
for i := 0; i < b.N; i++ {
_, err := datastore.GetManyImageMetadata(ctx, ids)
require.NoError(b, err)
}
})
}

func BenchmarkImageUpsert(b *testing.B) {
if !features.FlattenImageData.Enabled() {
b.Skip("Image flattened data model is not enabled")
}
ctx := sac.WithAllAccess(context.Background())

testDB := pgtest.ForT(b)

db := testDB.DB

mockRisk := mockRisks.NewMockDataStore(gomock.NewController(b))
datastore := NewWithPostgres(pgStore.New(db, false, keyfence.ImageKeyFenceSingleton()), mockRisk, ranking.NewRanker(), ranking.NewRanker())

images := make([]*storage.ImageV2, 0, 100)
for i := 0; i < 100; i++ {
img := fixtures.GetImageV2WithUniqueComponents(5)
img.Id = uuid.NewV4().String()
images = append(images, img)
}

b.Run("UpsertImage", func(b *testing.B) {
for i := 0; i < b.N; i++ {
for _, img := range images {
require.NoError(b, datastore.UpsertImage(ctx, img))
}
}
})
}
Loading