tests: define /tmp/k8s-service-logs in a single place only.#17184
Merged
tests: define /tmp/k8s-service-logs in a single place only.#17184
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
/test all |
Contributor
|
Images are ready for the commit at b19941a. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17184 +/- ##
==========================================
+ Coverage 48.80% 48.82% +0.01%
==========================================
Files 2714 2715 +1
Lines 203120 203156 +36
==========================================
+ Hits 99138 99189 +51
+ Misses 96159 96151 -8
+ Partials 7823 7816 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
porridge
added
the
auto-retest
Contributor
Author
|
/retest |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
|
/retest |
tommartensen
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backround: I'd like us to collect additional OLM artifacts in case of failed operator installation/upgrade.
However knowing where to drop them off for gathering into the additional stackrox e2e artifacts bucket is not so simple.
This is because we sometimes collect to
/tmp/k8s-service-logsand sometimes to a more elaborate path like.../part-1/k8s-logs. There probably are other paths too. And these paths are sprinkled as magic strings all over the codebase.Before:
While providing some convenience, the practice of repeating such path in multiple places makes it really hard to evolve the codebase. This is a baby step towards taking this under control.
After:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
I carefully looked at where and how each script is being invoked and made sure no call omits the now-mandatory arguments. Then I had claude double check.
My prompt:
It said:
I also had a look at the logs from all triggered CI jobs, and there were no unexpected occurrences of
Usage: ...error messages.