Skip to content

ROX-30941: Correct 'getDeduperAction' details #17108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikin91 merged 2 commits into from
Oct 7, 2025
Merged

ROX-30941: Correct 'getDeduperAction' details #17108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2506819
Empty commit
vikin91 Oct 2, 2025
bf2cc4a
Clarify situation with 'deduperActionUpdateProcess' for connections
vikin91 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions sensor/common/networkflow/updatecomputer/transition_based.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func (c *TransitionBased) ComputeUpdatedConns(current map[indicator.NetworkConn]
update, transition := categorizeUpdate(prevTS, currTS, prevTsFound, key, c.connectionsDeduper, &c.connectionsDeduperMutex)
updateMetrics(update, transition, ee)
// Each transition may require updating the deduper.
action := getDeduperAction(transition)
action := getConnectionDeduperAction(transition)
switch action {
case deduperActionAdd:
c.connectionsDeduper.Add(key)
Expand Down Expand Up @@ -243,8 +243,8 @@ func categorizeUpdate(

}

// getDeduperAction returns action to be executed on a deduper (or noop) for a given transition between states.
func getDeduperAction(tt TransitionType) deduperAction {
// getConnectionDeduperAction returns action to be executed on a deduper (or noop) for a given transition between states.
func getConnectionDeduperAction(tt TransitionType) deduperAction {
switch tt {
case TransitionTypeOpen2Closed:
// When a previously open EE is being closed, we must remove it from the deduper.
Expand All @@ -256,10 +256,6 @@ func getDeduperAction(tt TransitionType) deduperAction {
// Rarity. An EE was closed in the previous tick, but now is open.
// We treat is as a new EE and thus add it to deduper.
return deduperActionAdd
case TransitionTypeOpen2Open:
// Applicable to endpoints. If we get two open messages for the same endpoint, it may mean that the process
// has been updated, so we must update the deduper.
return deduperActionUpdateProcess
default:
// All other cases:
// 1. Closed -> Closed - the first observation of closed EE would remove it from deduper.
Expand Down
Loading