ROX-28151: limit the number of registries#16773
Merged
parametalol merged 2 commits intomasterfrom Sep 26, 2025
Merged
Conversation
parametalol
changed the title
parametalol
force-pushed
the
michael/ROX-28151-registry-cleanup
branch
from
a88508c to
d9d376a
Compare
parametalol
force-pushed
the
michael/ROX-28151-registries-limit
branch
from
b80149c to
f7cf578
Compare
Contributor
|
Images are ready for the commit at b5f3477. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16773 +/- ##
==========================================
- Coverage 48.81% 48.81% -0.01%
==========================================
Files 2706 2706
Lines 202028 202038 +10
==========================================
+ Hits 98616 98618 +2
- Misses 95651 95657 +6
- Partials 7761 7763 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janisz
approved these changes
Sep 15, 2025
parametalol
force-pushed
the
michael/ROX-28151-registry-cleanup
branch
from
f4ae8f9 to
dc7da70
Compare
parametalol
force-pushed
the
michael/ROX-28151-registries-limit
branch
from
f7cf578 to
b04e6fa
Compare
parametalol
force-pushed
the
michael/ROX-28151-registry-cleanup
branch
from
dc7da70 to
3511616
Compare
parametalol
force-pushed
the
michael/ROX-28151-registries-limit
branch
from
b04e6fa to
2170e00
Compare
parametalol
force-pushed
the
michael/ROX-28151-registry-cleanup
branch
from
3511616 to
57c7d2d
Compare
parametalol
force-pushed
the
michael/ROX-28151-registries-limit
branch
2 times, most recently
from
376bd5c to
d57be59
Compare
Base automatically changed from
michael/ROX-28151-registry-cleanup
to
master
September 26, 2025 16:23
parametalol
force-pushed
the
michael/ROX-28151-registries-limit
branch
from
d57be59 to
b5f3477
Compare
|
@parametalol: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case of an abuse from users, central may create too many in-memory Prometheus registries — one per user identity. The scope of this PR is to set a maximum number of such registries, and reject new requests to the
<API>/metricsendpoint for new identities.User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI
Current dependencies on/for this PR: