Skip to content

ROX-30390: Remove gauge metric for update types #16769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikin91 merged 2 commits into from
Sep 12, 2025
Merged

ROX-30390: Remove gauge metric for update types #16769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40fd999
Empty commit
vikin91 Sep 11, 2025
858d48c
Remove metric UpdateEventsGauge
vikin91 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions sensor/common/networkflow/updatecomputer/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
func init() {
prometheus.MustRegister(
UpdateEvents,
UpdateEventsGauge,
periodicCleanupDurationSeconds,
)
}
Expand All @@ -22,14 +21,6 @@ var (
"The 'transition' allows counting the transitions of connections between states 'open' and 'closed'." +
"Action stores the decision whether a given update was sent to Central.",
}, []string{"transition", "entity", "action", "reason"})
UpdateEventsGauge = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Namespace: metrics.PrometheusNamespace,
Subsystem: metrics.SensorSubsystem.String(),
Name: "update_computer_update_events_current",
Help: "Counts the internal update events for the categorizeUpdate method in TransitionBased updateComputer in a single tick. " +
"The 'transition' allows counting the transitions of connections between states 'open' and 'closed'. in a given tick." +
"Action stores the decision whether a given update was sent to Central.",
}, []string{"transition", "entity", "action", "reason"})
periodicCleanupDurationSeconds = prometheus.NewHistogram(prometheus.HistogramOpts{
Namespace: metrics.PrometheusNamespace,
Subsystem: metrics.SensorSubsystem.String(),
Expand Down
6 changes: 0 additions & 6 deletions sensor/common/networkflow/updatecomputer/transition_based.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,6 @@ func NewTransitionBased() *TransitionBased {
func (c *TransitionBased) ComputeUpdatedConns(current map[indicator.NetworkConn]timestamp.MicroTS) []*storage.NetworkFlow {
var updates []*storage.NetworkFlow
ee := ConnectionEnrichedEntity
// Reset the gauge metric only on the first call to the ComputeUpdated.
// The current state assumes that `ComputeUpdatedConns` is always called before other ComputeUpdated functions.
// Calling Reset in other ComputeUpdated functions would remove the data collected in the metric in this function.
UpdateEventsGauge.Reset()
if len(current) == 0 {
// Received an empty map with current state. This may happen because:
// - Some items were discarded during the enrichment process, so none made it through.
Expand Down Expand Up @@ -292,8 +288,6 @@ func updateMetrics(update bool, tt TransitionType, ee EnrichedEntity) {
}
}
UpdateEvents.WithLabelValues(tt.String(), string(ee), action, reason).Inc()
// This metric must be reset on each tick, otherwise it would behave as a counter.
UpdateEventsGauge.WithLabelValues(tt.String(), string(ee), action, reason).Inc()
}

// categorizeUpdateNoPast determines whether an update to Central should be sent for a given enrichment update.
Expand Down
Loading