refactor(phonehome): MetricsConfiguration → MetricDescriptors#16724
Merged
parametalol merged 1 commit intomasterfrom Sep 9, 2025
Merged
refactor(phonehome): MetricsConfiguration → MetricDescriptors#16724parametalol merged 1 commit intomasterfrom
MetricsConfiguration → MetricDescriptors#16724parametalol merged 1 commit intomasterfrom
Conversation
parametalol
changed the title
MetricsConfiguration to MetricDescriptorsMetricsConfiguration → MetricDescriptors
Contributor
|
Images are ready for the commit at 0a0587e. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16724 +/- ##
==========================================
- Coverage 48.67% 48.66% -0.02%
==========================================
Files 2674 2675 +1
Lines 199708 199760 +52
==========================================
+ Hits 97213 97216 +3
- Misses 94886 94935 +49
Partials 7609 7609
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janisz
approved these changes
Sep 9, 2025
Contributor
janisz
left a comment
janisz
left a comment
There was a problem hiding this comment.
LGTM, but please explain why we need this and maybe link a comment that requested it
ksurabhi91
pushed a commit
that referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type renaming to reduce confusion of various Configuration types, such as in:
Spot in #15796 (comment)
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI.