-
Notifications
You must be signed in to change notification settings - Fork 174
ROX-30578: Configure process baseline auto locking via helm #16462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoukoVirtanen
merged 30 commits into
master
from
jv-ROX-30578-configure-process-baseline-auto-locking-via-helm
Oct 1, 2025
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
88372ac
X-Smart-Branch-Parent: master
JoukoVirtanen 79addc5
Added autolockProcessBaseline.enabled to helm
JoukoVirtanen 875d758
Helm config is used if the manage type is not manual
JoukoVirtanen a421cd1
Deploy script sets process autolocking via helm
JoukoVirtanen e2afdd9
Fixed style
JoukoVirtanen 210bb06
Modified test case for better code coverage
JoukoVirtanen 0d1b275
Fixes after rebase
JoukoVirtanen 314ec76
More fixes after rebase
JoukoVirtanen 3aad4b8
Set default for SECURED_CLUSTER_AUTOLOCK_PROCESS_BASELINE
JoukoVirtanen 8eed7a2
Set a default for the setting
JoukoVirtanen 84b7516
Changed autolock to autoLock
JoukoVirtanen 8cfdf93
Fixes after another rebase
JoukoVirtanen 1b3da85
Changed autoLockProcessBaseline to autoLockProcessBaselines
JoukoVirtanen fd51e28
Split tests. All of them should run
JoukoVirtanen 29a9105
Fixes after rebase
JoukoVirtanen 0b48835
Made env var plural
JoukoVirtanen a5f4db3
Added tests for process baseline auto locking
JoukoVirtanen fc2f283
Removed blank line
JoukoVirtanen 062f1c4
Added a unit test for manual managment
JoukoVirtanen 02a4f46
Changed feature flag env var to ROX_AUTO_LOCK_PROCESS_BASELINES
JoukoVirtanen ebd38f7
cluster-config uses autoLockProcessBaselinesConfig
JoukoVirtanen 11bfe7a
Fixed test
JoukoVirtanen e750516
Using feature flag in 30-base-config.yaml.htpl
JoukoVirtanen 669b033
Changed ROX_AUTOLOCK_PROCESS_BASELINES to ROX_AUTO_LOCK_PROCESS_BASEL…
JoukoVirtanen 3843997
When the feature is not enabled the feature doesn't appear in the hel…
JoukoVirtanen 613d41a
Fixed indentation
JoukoVirtanen 35a4c28
Not using a feature flag in 30-base-config.yaml.htpl anymore
JoukoVirtanen e72ed16
Reverted change to test
JoukoVirtanen 2dad5a9
Changed cluster-config.yaml.tpl to cluster-config.yaml.tpl.htpl. Adde…
JoukoVirtanen 2917cf7
Unit tests are now dependent upon the feature flag
JoukoVirtanen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
...ata/helmtest/auto-lock-process-baselines-disabled/process-baseline-auto-locking.test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| values: | ||
| imagePullSecrets: | ||
| allowNone: true | ||
| tests: | ||
| - name: "Process baseline auto-locking should not exist since the feature flag is disabled even if it is enabled in the secured cluster" | ||
| values: | ||
| autoLockProcessBaselines: | ||
| enabled: true | ||
| expect: | | ||
| .secrets["helm-cluster-config"].stringData["config.yaml"] | fromyaml | .clusterConfig.dynamicConfig.autoLockProcessBaselinesConfig.enabled | assertThat(. == null) | ||
| - name: "Process baseline auto-locking should not exist" | ||
| values: | ||
| autoLockProcessBaelines: | ||
| enabled: false | ||
| expect: | | ||
| .secrets["helm-cluster-config"].stringData["config.yaml"] | fromyaml | .clusterConfig.dynamicConfig.autoLockProcessBaselinesConfig.enabled | assertThat(. == null) |
16 changes: 16 additions & 0 deletions
16
...ags/testdata/helmtest/auto-lock-process-baselines/process-baseline-auto-locking.test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| values: | ||
| imagePullSecrets: | ||
| allowNone: true | ||
| tests: | ||
| - name: "Process baseline auto-locking should be enabled" | ||
| values: | ||
| autoLockProcessBaselines: | ||
| enabled: true | ||
| expect: | | ||
| .secrets["helm-cluster-config"].stringData["config.yaml"] | fromyaml | .clusterConfig.dynamicConfig.autoLockProcessBaselinesConfig.enabled | assertThat(. == true) | ||
| - name: "Process baseline auto-locking should be disabled" | ||
| values: | ||
| autoLockProcessBaelines: | ||
| enabled: false | ||
| expect: | | ||
| .secrets["helm-cluster-config"].stringData["config.yaml"] | fromyaml | .clusterConfig.dynamicConfig.autoLockProcessBaselinesConfig.enabled | assertThat(. == false) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.