Skip to content

feat(authn): Copy Context identity helper#15808

Merged
parametalol merged 2 commits intomasterfrom
michael/authn-copy-context-identity
Aug 14, 2025
Merged

feat(authn): Copy Context identity helper#15808
parametalol merged 2 commits intomasterfrom
michael/authn-copy-context-identity

Conversation

@parametalol
Copy link
Copy Markdown
Contributor

@parametalol parametalol commented Jun 23, 2025

Description

CopyContextIdentity copies the identity from one context to another.
This helps to detach the identity information from a cancellable context when passing, e.g. http.Request context to a goroutine.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Unit tests.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jun 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Jun 23, 2025

Images are ready for the commit at a719ed0.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-498-ga719ed0f51.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.12%. Comparing base (c263c1b) to head (a719ed0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15808      +/-   ##
==========================================
+ Coverage   49.07%   49.12%   +0.05%     
==========================================
  Files        2640     2646       +6     
  Lines      195598   195841     +243     
==========================================
+ Hits        95982    96203     +221     
- Misses      92107    92122      +15     
- Partials     7509     7516       +7     
Flag Coverage Δ
go-unit-tests 49.12% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch 2 times, most recently from 922752c to 232068a Compare August 14, 2025 07:56
@parametalol parametalol force-pushed the michael/authn-copy-context-identity branch from a8c335e to a719ed0 Compare August 14, 2025 08:02
@parametalol parametalol changed the base branch from michael/ROX-28151-cached-tracker to master August 14, 2025 08:02
@github-actions github-actions bot added ci-all-qa-tests Tells CI to run all API tests (not just BAT). area/central area/ci konflux-build Run Konflux in PR. Push commit to trigger it. labels Aug 14, 2025
@parametalol parametalol marked this pull request as ready for review August 14, 2025 08:04
@parametalol parametalol changed the title chore(authn): Copy Context identity helper feat(authn): Copy Context identity helper Aug 14, 2025
@parametalol parametalol enabled auto-merge (squash) August 14, 2025 08:16
@parametalol parametalol merged commit 844f09b into master Aug 14, 2025
102 of 118 checks passed
@parametalol parametalol deleted the michael/authn-copy-context-identity branch August 14, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/central area/ci ci-all-qa-tests Tells CI to run all API tests (not just BAT). konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants