ROX-28151: Prometheus registry for custom metrics#15807
Closed
parametalol wants to merge 1 commit intomichael/ROX-28151-minimal-aggregatorfrom
Closed
ROX-28151: Prometheus registry for custom metrics#15807parametalol wants to merge 1 commit intomichael/ROX-28151-minimal-aggregatorfrom
parametalol wants to merge 1 commit intomichael/ROX-28151-minimal-aggregatorfrom
Conversation
|
Skipping CI for Draft Pull Request. |
This was referenced Jun 23, 2025
parametalol
changed the title
Contributor
|
Images are ready for the commit at c957700. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## michael/ROX-28151-minimal-aggregator #15807 +/- ##
=====================================================================
Coverage 49.09% 49.10%
=====================================================================
Files 2644 2645 +1
Lines 195830 195855 +25
=====================================================================
+ Hits 96151 96182 +31
+ Misses 92163 92159 -4
+ Partials 7516 7514 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
9 tasks
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
from
018086d to
43dd7da
Compare
parametalol
force-pushed
the
michael/ROX-28151-minimal-custom-registry
branch
from
5bdddbb to
b1fff5d
Compare
stehessel
approved these changes
Aug 13, 2025
parametalol
force-pushed
the
michael/ROX-28151-minimal-custom-registry
branch
2 times, most recently
from
4129676 to
aa7a747
Compare
parametalol
requested review from
a team,
adisos,
janisz and
zivnevo
as code owners
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
from
30d5b00 to
7df7ad8
Compare
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
from
7df7ad8 to
30cee42
Compare
parametalol
force-pushed
the
michael/ROX-28151-minimal-custom-registry
branch
from
aa7a747 to
c957700
Compare
9 tasks
Contributor
Author
|
Merged within #15797. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A custom Prometheus registry serves the aggregated metrics, and is separated from the default registry that serves other general central metrics.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI
Current dependencies on/for this PR: