ROX-28151: Tracker runner, triggered by Prometheus scrape request by parametalol · Pull Request #15797 · stackrox/stackrox

parametalol · 2025-06-19T14:51:47Z

Description

Custom Prometheus metrics exposed on the /metrics path of the central API endpoint. Configured via the /v1/config service.

This PR adds the image vulnerabilities tracker and sets it up on a dedicated route, and enables configuration via the config service API.

Disabled by default.

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

How I validated my change

CI

Current dependencies on/for this PR:

master
- PR ROX-28151: Custom Prometheus metrics minimal configuration #15783
  - PR ROX-28151: Custom Prometheus metrics minimal aggregator #15784
    - PR ROX-28151: Prometheus registry for custom metrics #15807
      - PR ROX-28151: Tracker, triggered by Prometheus scrape request #15796
        
        PR ROX-28151: Tracker runner, triggered by Prometheus scrape request #15797 👈
        
        PR ROX-28151: Prometheus registry per user token #15809
        
        PR ROX-28151: Phonehome telemetry for custom Prometheus metrics #15487
        
        PR ROX-28151: custom registry cleanup #16176
        
        PR ROX-29523: Custom Prometheus metrics minimal UI #15782

openshift-ci · 2025-06-19T14:51:51Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2025-06-19T15:29:53Z

Codecov Report

❌ Patch coverage is 75.73333% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.68%. Comparing base (a75e8cd) to head (924e8b3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
central/metrics/custom/tracker/tracker_base.go	71.77%	30 Missing and 5 partials ⚠️
central/metrics/custom/runner.go	62.00%	12 Missing and 7 partials ⚠️
...ral/metrics/custom/image_vulnerabilities/labels.go	30.00%	14 Missing ⚠️
central/config/service/service.go	46.15%	7 Missing ⚠️
...al/metrics/custom/image_vulnerabilities/tracker.go	82.35%	4 Missing and 2 partials ⚠️
central/metrics/custom/singleton.go	0.00%	6 Missing ⚠️
central/metrics/custom/tracker/aggregator.go	91.17%	2 Missing and 1 partial ⚠️
central/config/service/singleton.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #15797      +/-   ##
==========================================
+ Coverage   48.62%   48.68%   +0.05%     
==========================================
  Files        2664     2674      +10     
  Lines      199336   199708     +372     
==========================================
+ Hits        96932    97219     +287     
- Misses      94809    94882      +73     
- Partials     7595     7607      +12

Flag	Coverage Δ
go-unit-tests	`48.68% <75.73%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rhacs-bot · 2025-06-20T16:28:52Z

Images are ready for the commit at 924e8b3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-719-g924e8b39b0.

central/metrics/custom/singleton.go

stehessel

I like the idea of using the Prometheus registry as a cache that is invalidated upon user request. What is not clear to me is how stale labels get purged from the cache? IIUC stale findings from previous gathers remain as metrics in the registry - is that right? Ideally these stale findings would be purged after the gathering period expired.

central/metrics/custom_registry.go

CHANGELOG.md

openshift-ci · 2025-09-08T16:29:16Z

@parametalol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ocp-4-18-nongroovy-e2e-tests	`7058c8a`	link	false	`/test ocp-4-18-nongroovy-e2e-tests`
ci/prow/ocp-4-12-operator-e2e-tests	`924e8b3`	link	false	`/test ocp-4-12-operator-e2e-tests`
ci/prow/ocp-4-12-nongroovy-e2e-tests	`924e8b3`	link	false	`/test ocp-4-12-nongroovy-e2e-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress label Jun 19, 2025

github-actions bot added the area/central label Jun 19, 2025

parametalol force-pushed the michael/ROX-28151-cached-runner branch from 013331f to e7f93c7 Compare June 20, 2025 13:48

parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 4cf2b93 to 25e1bb8 Compare June 20, 2025 13:48

parametalol force-pushed the michael/ROX-28151-cached-runner branch from e7f93c7 to a76cb2a Compare June 20, 2025 15:56

parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 60b7302 to 17d90da Compare June 20, 2025 19:36

parametalol force-pushed the michael/ROX-28151-cached-runner branch from a76cb2a to a7eaed4 Compare June 20, 2025 19:36

parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 17d90da to 64d7b55 Compare June 23, 2025 09:39

parametalol force-pushed the michael/ROX-28151-cached-runner branch from a7eaed4 to b2392c1 Compare June 23, 2025 09:59

parametalol changed the base branch from michael/ROX-28151-cached-tracker to michael/authn-copy-context-identity June 23, 2025 14:01

parametalol mentioned this pull request Jun 23, 2025

ROX-29523: Custom Prometheus metrics minimal UI #15782

Merged

9 tasks

parametalol changed the title ~~michael/ROX-28151-cached-runner~~ ROX-28151: Tracker runner, triggered by Prometheus scrape request Jun 23, 2025

parametalol force-pushed the michael/ROX-28151-cached-runner branch from 9430e5c to fe18a4b Compare July 2, 2025 07:42

parametalol mentioned this pull request Jul 16, 2025

ROX-28151: Phonehome telemetry for custom Prometheus metrics #15487

Merged

9 tasks

parametalol mentioned this pull request Jul 28, 2025

ROX-28151: custom registry cleanup #16176

Merged

9 tasks

parametalol force-pushed the michael/authn-copy-context-identity branch from a8c335e to a719ed0 Compare August 14, 2025 08:02

parametalol changed the base branch from michael/authn-copy-context-identity to michael/ROX-28151-cached-tracker August 14, 2025 08:17

parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 232068a to 96cfe28 Compare August 14, 2025 08:24

parametalol force-pushed the michael/ROX-28151-cached-runner branch 2 times, most recently from 11b8374 to 7dba6d0 Compare August 14, 2025 11:51

parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 96cfe28 to 38551df Compare August 14, 2025 11:51

stehessel reviewed Sep 3, 2025

View reviewed changes

central/metrics/custom/singleton.go Outdated Show resolved Hide resolved

stehessel reviewed Sep 3, 2025

View reviewed changes

parametalol commented Sep 5, 2025

View reviewed changes

central/metrics/custom_registry.go Outdated Show resolved Hide resolved

parametalol requested a review from stehessel September 5, 2025 09:10

stehessel approved these changes Sep 5, 2025

View reviewed changes

parametalol mentioned this pull request Sep 8, 2025

ROX-28151: Custom Prometheus metrics minimal runner #15780

Closed

9 tasks

parametalol changed the base branch from michael/ROX-28151-cached-tracker to master September 8, 2025 14:06

parametalol and others added 18 commits September 8, 2025 16:21

minimal configuration

0c5c7eb

aggregator

6f567c7

CustomRegistry

c60a266

tracker

c38f909

added a test, removed unused (here) method, nits

11124ab

logging finding error

da10075

cached runner

0eaf539

CHANGELOG.md

add global access scope checker

56786a7

unexport validateConfiguration

abc9ebd

reshuffle tracker configuration a little

a359e9d

unused variable removed

c8d3b6c

nit

c0eef19

extract runner from singleton

96d587a

typo

d5bd75e

style

6481815

nit: comment

cff30be

reset custom registry

3d1684c

Apply suggestion from @parametalol

924e8b3

parametalol force-pushed the michael/ROX-28151-cached-runner branch from 7058c8a to 924e8b3 Compare September 8, 2025 14:22

parametalol enabled auto-merge (squash) September 8, 2025 15:41

parametalol merged commit cccc762 into master Sep 8, 2025
90 of 98 checks passed

parametalol deleted the michael/ROX-28151-cached-runner branch September 8, 2025 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROX-28151: Tracker runner, triggered by Prometheus scrape request#15797

ROX-28151: Tracker runner, triggered by Prometheus scrape request#15797
parametalol merged 18 commits intomasterfrom
michael/ROX-28151-cached-runner

parametalol commented Jun 19, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Jun 19, 2025

Uh oh!

codecov bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

rhacs-bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

stehessel left a comment •

edited

Loading

Uh oh!

Uh oh!

openshift-ci bot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

parametalol commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

openshift-ci bot commented Jun 19, 2025

Uh oh!

codecov bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rhacs-bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

stehessel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci bot commented Sep 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

parametalol commented Jun 19, 2025 •

edited

Loading

codecov bot commented Jun 19, 2025 •

edited

Loading

rhacs-bot commented Jun 20, 2025 •

edited

Loading

stehessel left a comment •

edited

Loading