Skip to content

ROX-28151: Tracker, triggered by Prometheus scrape request#15796

Closed
parametalol wants to merge 3 commits intomichael/ROX-28151-minimal-custom-registryfrom
michael/ROX-28151-cached-tracker
Closed

ROX-28151: Tracker, triggered by Prometheus scrape request#15796
parametalol wants to merge 3 commits intomichael/ROX-28151-minimal-custom-registryfrom
michael/ROX-28151-cached-tracker

Conversation

@parametalol
Copy link
Copy Markdown
Contributor

@parametalol parametalol commented Jun 19, 2025 •
edited
Loading

Description

A Tracker is a generic implementation of a custom metric aggregator, that exposes the metrics on a custom Prometheus registry. Vulnerability and other metrics will be tracked by specializations of this generic implementation.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

Current dependencies on/for this PR:

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jun 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@parametalol parametalol mentioned this pull request Jun 19, 2025
Merged
9 tasks
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Jun 19, 2025 •
edited
Loading

Images are ready for the commit at a8f0362.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-518-ga8f036222d.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.84071% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.12%. Comparing base (c957700) to head (a8f0362).

Files with missing lines Patch % Lines
central/metrics/custom/tracker/tracker_base.go 83.50% 11 Missing and 5 partials ⚠️
Additional details and impacted files 
@@                              Coverage Diff                              @@
##           michael/ROX-28151-minimal-custom-registry   #15796      +/-   ##
=============================================================================
+ Coverage                                      49.10%   49.12%   +0.01%     
=============================================================================
  Files                                           2645     2646       +1     
  Lines                                         195855   195966     +111     
=============================================================================
+ Hits                                           96182    96266      +84     
- Misses                                         92159    92178      +19     
- Partials                                        7514     7522       +8
Flag Coverage Δ
go-unit-tests 49.12% <85.84%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 4cf2b93 to 25e1bb8 Compare June 20, 2025 13:48
@parametalol parametalol force-pushed the michael/ROX-28151-minimal-aggregator branch from 7732818 to 11697ee Compare June 20, 2025 13:48
@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 60b7302 to 17d90da Compare June 20, 2025 19:36
@parametalol parametalol force-pushed the michael/ROX-28151-minimal-aggregator branch 2 times, most recently from 0d622e8 to 018086d Compare June 23, 2025 09:19
@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 17d90da to 64d7b55 Compare June 23, 2025 09:39
This was referenced Jun 23, 2025
Closed
Merged
Merged
Closed
Closed
@parametalol parametalol changed the base branch from michael/ROX-28151-minimal-aggregator to michael/ROX-28151-minimal-custom-registry June 23, 2025 14:01
@parametalol parametalol mentioned this pull request Jun 23, 2025
Merged
9 tasks
@parametalol parametalol changed the title michael/ROX-28151-cached-tracker ROX-28151: Tracker, triggered by Prometheus scrape request Jun 23, 2025
@parametalol parametalol mentioned this pull request Jul 16, 2025
Merged
9 tasks
@parametalol parametalol mentioned this pull request Jul 28, 2025
Merged
9 tasks
@parametalol parametalol force-pushed the michael/ROX-28151-minimal-custom-registry branch from 5bdddbb to b1fff5d Compare August 13, 2025 08:33
@parametalol parametalol requested a review from stehessel August 13, 2025 08:52
@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 64d7b55 to 05ffe8b Compare August 13, 2025 08:59
@parametalol parametalol marked this pull request as ready for review August 13, 2025 08:59
@parametalol parametalol force-pushed the michael/ROX-28151-minimal-custom-registry branch from b1fff5d to 63b1042 Compare August 14, 2025 07:55
@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch 2 times, most recently from 232068a to 96cfe28 Compare August 14, 2025 08:24
@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 96cfe28 to 38551df Compare August 14, 2025 11:51
@parametalol parametalol requested review from porridge and removed request for a team August 14, 2025 11:51
@parametalol parametalol force-pushed the michael/ROX-28151-minimal-custom-registry branch from 4129676 to aa7a747 Compare August 14, 2025 11:51
@parametalol parametalol force-pushed the michael/ROX-28151-minimal-custom-registry branch from aa7a747 to c957700 Compare August 18, 2025 09:58
@parametalol parametalol force-pushed the michael/ROX-28151-cached-tracker branch from 38551df to 30dd97b Compare August 18, 2025 09:58
@parametalol parametalol mentioned this pull request Aug 18, 2025
Merged
9 tasks
stehessel
stehessel reviewed Aug 28, 2025
View reviewed changes
@shireenf-ibm shireenf-ibm removed their request for review August 28, 2025 08:39
@parametalol parametalol mentioned this pull request Sep 8, 2025
Closed
9 tasks
@parametalol
Copy link
Copy Markdown
Contributor Author

parametalol commented Sep 8, 2025

Merged within #15797.

@parametalol parametalol closed this Sep 8, 2025
@parametalol parametalol mentioned this pull request Sep 9, 2025
Merged
9 tasks
@parametalol parametalol deleted the michael/ROX-28151-cached-tracker branch September 16, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stehessel stehessel stehessel approved these changes

@janisz janisz Awaiting requested review from janisz

@zivnevo zivnevo Awaiting requested review from zivnevo

@adisos adisos Awaiting requested review from adisos

@porridge porridge Awaiting requested review from porridge porridge was automatically assigned from stackrox/install

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@parametalol @rhacs-bot @stehessel @janisz