ROX-28151: Custom Prometheus metrics minimal tracker#15785
Closed
parametalol wants to merge 4 commits intomichael/ROX-28151-minimal-aggregatorfrom
Closed
ROX-28151: Custom Prometheus metrics minimal tracker#15785parametalol wants to merge 4 commits intomichael/ROX-28151-minimal-aggregatorfrom
parametalol wants to merge 4 commits intomichael/ROX-28151-minimal-aggregatorfrom
Conversation
|
Skipping CI for Draft Pull Request. |
9 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## michael/ROX-28151-minimal-aggregator #15785 +/- ##
========================================================================
+ Coverage 48.80% 48.83% +0.03%
========================================================================
Files 2590 2598 +8
Lines 190522 190942 +420
========================================================================
+ Hits 92983 93256 +273
- Misses 90237 90378 +141
- Partials 7302 7308 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Images are ready for the commit at 82c9455. To use with deploy scripts, first |
This was referenced Jun 18, 2025
parametalol
changed the title
This was referenced Jun 19, 2025
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
3 times, most recently
from
0d622e8 to
018086d
Compare
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
3 times, most recently
from
7df7ad8 to
30cee42
Compare
Contributor
Author
|
Closed in favour of #15796 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds base implementation for metrics tracker. A tracker is a process, configured with the list of labels, their order, and aggregation period. The label order is used for building a consistent aggregation key.
A tracker manages a ticker and the tracking loop goroutine.
Image vulnerabilities metrics will be handled by one tracker instance, policy violations — by another.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Unit tests.
Current dependencies on/for this PR: