ROX-28151: Custom Prometheus metrics minimal aggregator#15784
Closed
parametalol wants to merge 1 commit intomichael/ROX-28151-minimal-configurationfrom
Closed
ROX-28151: Custom Prometheus metrics minimal aggregator#15784parametalol wants to merge 1 commit intomichael/ROX-28151-minimal-configurationfrom
parametalol wants to merge 1 commit intomichael/ROX-28151-minimal-configurationfrom
Conversation
|
Skipping CI for Draft Pull Request. |
This was referenced Jun 18, 2025
Contributor
|
Images are ready for the commit at 30cee42. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## michael/ROX-28151-minimal-configuration #15784 +/- ##
===========================================================================
+ Coverage 49.08% 49.09% +0.01%
===========================================================================
Files 2642 2644 +2
Lines 195747 195830 +83
===========================================================================
+ Hits 96081 96151 +70
- Misses 92159 92163 +4
- Partials 7507 7516 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jun 18, 2025
parametalol
changed the title
This was referenced Jun 19, 2025
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
3 times, most recently
from
0d622e8 to
018086d
Compare
This was referenced Jun 23, 2025
9 tasks
9 tasks
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
from
018086d to
43dd7da
Compare
Contributor
Author
|
/retest |
stehessel
reviewed
Aug 13, 2025
Collaborator
stehessel
left a comment
stehessel
left a comment
There was a problem hiding this comment.
The code looks correct to me, but I think even more examples would go a long way here to take away some of the abstraction and complexity introduced by the custom types.
stehessel
approved these changes
Aug 13, 2025
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
from
30d5b00 to
7df7ad8
Compare
parametalol
requested review from
a team,
adisos,
janisz,
shireenf-ibm and
zivnevo
as code owners
parametalol
temporarily deployed
to
development
GitHub Actions
Inactive
parametalol
force-pushed
the
michael/ROX-28151-minimal-configuration
branch
from
841e4a0 to
25f4739
Compare
parametalol
force-pushed
the
michael/ROX-28151-minimal-configuration
branch
from
25f4739 to
a91a09a
Compare
parametalol
force-pushed
the
michael/ROX-28151-minimal-aggregator
branch
from
7df7ad8 to
30cee42
Compare
9 tasks
Contributor
Author
|
Merged within #15797. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces the data aggregation logic to support custom Prometheus metrics.
Every piece of source data sent for aggregation is called a finding. The aggregation process builds an aggregation key, which serves as the key for the aggregated numbers map.
For example, the keys for a single "Severity" label will be 4 known severity levels (LOW to CRITICAL), the aggregation map will have a key for each severity, and the number of findings as the value.
For multiple labels, the key is a joined value of all labels.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Unit tests.
Current dependencies on/for this PR: