ROX-29523: Custom Prometheus metrics minimal UI by parametalol · Pull Request #15782 · stackrox/stackrox

parametalol · 2025-06-18T13:32:38Z

Description

This PR introduces some basic configuration for the custom Prometheus metrics feature.

A small set of predefined metrics is hardcoded in the frontend, and compared with the current configuration. The real configuration may have a random set of metrics, created via API or selected from the UI.

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

How I validated my change

Manual tests.

One of the predefined metric is enabled

One predefined and one custom metrics are enabled

No metrics enabled

Edit mode
No custom metrics:

One custom metric:

One custom, one enabled predefined and one overridden predefined metrics:

Current dependencies on/for this PR:

master
- PR ROX-28151: Custom Prometheus metrics minimal configuration #15783
  - PR ROX-28151: Custom Prometheus metrics minimal aggregator #15784
    - PR ROX-28151: Prometheus registry for custom metrics #15807
      - PR ROX-28151: Tracker, triggered by Prometheus scrape request #15796
        
        PR ROX-28151: Tracker runner, triggered by Prometheus scrape request #15797
        
        PR ROX-28151: Prometheus registry per user token #15809
        
        PR ROX-28151: Phonehome telemetry for custom Prometheus metrics #15487
        
        PR ROX-28151: custom registry cleanup #16176
        
        PR ROX-29523: Custom Prometheus metrics minimal UI #15782 👈

openshift-ci · 2025-06-18T13:32:43Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

rhacs-bot · 2025-06-18T14:08:35Z

Images are ready for the commit at 16ce174.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-1022-g16ce17406e.

codecov · 2025-06-18T14:16:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.82%. Comparing base (c021965) to head (16ce174).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #15782      +/-   ##
==========================================
- Coverage   48.83%   48.82%   -0.01%     
==========================================
  Files        2714     2715       +1     
  Lines      203120   203177      +57     
==========================================
+ Hits        99197    99205       +8     
- Misses      96113    96154      +41     
- Partials     7810     7818       +8

Flag	Coverage Δ
go-unit-tests	`48.82% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ui/apps/platform/src/Containers/SystemConfig/Form/SystemConfigForm.tsx

ui/apps/platform/src/Containers/SystemConfig/Details/components/PrometheusMetricsCard.tsx

pedrottimark

Tables are excellent improvement!

Two suggested changes to solve zero problem.

stehessel

LGTM 🚀. Note: I didn't review the typescript code, just the screenshots.

ui/apps/platform/src/Containers/SystemConfig/Details/SystemConfigDetails.tsx

parametalol · 2025-10-08T12:44:24Z

/retest

red-hat-konflux · 2025-10-08T12:44:31Z

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
central-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
main-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
operator-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
operator-bundle-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-collector	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
roxctl-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`

openshift-ci bot added the do-not-merge/work-in-progress label Jun 18, 2025

github-actions bot added the area/ui label Jun 18, 2025

parametalol changed the title ~~michael/ROX-28151-minimal-ui~~ ROX-28151: Custom Prometheus metrics minimal UI Jun 18, 2025

This was referenced Jun 19, 2025

ROX-28151: Tracker, triggered by Prometheus scrape request #15796

Closed

ROX-28151: Tracker runner, triggered by Prometheus scrape request #15797

Merged

parametalol force-pushed the michael/ROX-28151-minimal-ui branch from 5a90e41 to c6131d8 Compare June 23, 2025 14:00

This was referenced Jun 23, 2025

ROX-28151: Prometheus registry for custom metrics #15807

Closed

feat(authn): Copy Context identity helper #15808

Merged

ROX-28151: Prometheus registry per user token #15809

Merged

parametalol changed the base branch from michael/ROX-28151-minimal-runner to michael/ROX-28151-cached-runner June 23, 2025 14:01

parametalol force-pushed the michael/ROX-28151-cached-runner branch from 9430e5c to fe18a4b Compare July 2, 2025 07:42

parametalol mentioned this pull request Jul 16, 2025

ROX-28151: Phonehome telemetry for custom Prometheus metrics #15487

Merged

9 tasks

parametalol mentioned this pull request Jul 28, 2025

ROX-28151: custom registry cleanup #16176

Merged

9 tasks

parametalol force-pushed the michael/ROX-28151-cached-runner branch 3 times, most recently from 7dba6d0 to 4565760 Compare August 18, 2025 09:58

parametalol mentioned this pull request Aug 18, 2025

ROX-28151: policy violations exposed as Prometheus metrics #16434

Merged

9 tasks

parametalol force-pushed the michael/ROX-28151-cached-runner branch 2 times, most recently from 5f58398 to 680ac3e Compare September 1, 2025 09:09

parametalol force-pushed the michael/ROX-28151-minimal-ui branch from c6131d8 to 9e23e45 Compare September 3, 2025 15:54

parametalol changed the title ~~ROX-28151: Custom Prometheus metrics minimal UI~~ ROX-29523: Custom Prometheus metrics minimal UI Sep 3, 2025

parametalol marked this pull request as ready for review September 5, 2025 12:38

parametalol requested a review from a team as a code owner September 5, 2025 12:38

parametalol force-pushed the michael/ROX-28151-minimal-ui branch from 34dd9b3 to 00495ca Compare September 9, 2025 17:46

parametalol commented Sep 9, 2025

View reviewed changes

ui/apps/platform/src/Containers/SystemConfig/Form/SystemConfigForm.tsx Show resolved Hide resolved

parametalol mentioned this pull request Sep 11, 2025

ROX-28151: limit the number of registries #16773

Merged

9 tasks

parametalol force-pushed the michael/ROX-28151-minimal-ui branch from be121cd to a9275a7 Compare September 29, 2025 15:32

pedrottimark reviewed Oct 7, 2025

View reviewed changes

ui/apps/platform/src/Containers/SystemConfig/Details/components/PrometheusMetricsCard.tsx Outdated Show resolved Hide resolved

pedrottimark reviewed Oct 7, 2025

View reviewed changes

ui/apps/platform/src/Containers/SystemConfig/Details/components/PrometheusMetricsCard.tsx Outdated Show resolved Hide resolved

pedrottimark approved these changes Oct 7, 2025

View reviewed changes

parametalol and others added 14 commits October 8, 2025 10:01

prometheus metrics configuration ui

b36f606

proto types renaming, refactoring

d0c30e6

PrometheusMetricsCardProps

cee4636

nit

a44284f

refactor DataListItemRow

9d184f3

policy violations card and form

9f0dc36

keys in PrivateConfigPrometheusMetricsDetails

eb53baf

highlight metric prefixes

992c3ed

updated predefined metrics

58d49d1

node vulnerabilities card

fe2667b

table

7a3d613

reactify PrometheusMetricsPeriodForm

24b27d2

refactor card generation

83e1dab

remove "|| 0" to allow deleting 0

640330c

parametalol force-pushed the michael/ROX-28151-minimal-ui branch from a9275a7 to 640330c Compare October 8, 2025 09:35

stehessel approved these changes Oct 8, 2025

View reviewed changes

ui/apps/platform/src/Containers/SystemConfig/Details/SystemConfigDetails.tsx Outdated Show resolved Hide resolved

wording

f4a8ba6

fixed the predefined metrics

16ce174

parametalol removed the request for review from a team October 8, 2025 14:54

parametalol merged commit 757cb04 into master Oct 8, 2025
91 checks passed

parametalol deleted the michael/ROX-28151-minimal-ui branch October 8, 2025 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROX-29523: Custom Prometheus metrics minimal UI#15782

ROX-29523: Custom Prometheus metrics minimal UI#15782
parametalol merged 16 commits intomasterfrom
michael/ROX-28151-minimal-ui

parametalol commented Jun 18, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Jun 18, 2025

Uh oh!

rhacs-bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pedrottimark left a comment

Uh oh!

stehessel left a comment

Uh oh!

Uh oh!

parametalol commented Oct 8, 2025

Uh oh!

red-hat-konflux bot commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

parametalol commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

openshift-ci bot commented Jun 18, 2025

Uh oh!

rhacs-bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pedrottimark left a comment

Choose a reason for hiding this comment

Uh oh!

stehessel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parametalol commented Oct 8, 2025

Uh oh!

red-hat-konflux bot commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

parametalol commented Jun 18, 2025 •

edited

Loading

rhacs-bot commented Jun 18, 2025 •

edited

Loading

codecov bot commented Jun 18, 2025 •

edited

Loading