Skip to content

ROX-28151: Custom Prometheus metrics tracker#15744

Closed
parametalol wants to merge 9 commits intomichael/ROX-28151-aggregatorfrom
michael/ROX-28151-tracker
Closed

ROX-28151: Custom Prometheus metrics tracker#15744
parametalol wants to merge 9 commits intomichael/ROX-28151-aggregatorfrom
michael/ROX-28151-tracker

Conversation

@parametalol
Copy link
Copy Markdown
Contributor

@parametalol parametalol commented Jun 16, 2025

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Current dependencies on/for this PR:

@rhacs-bot
Copy link
Copy Markdown
Contributor

Images are ready for the commit at 7c5e09e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-59-g7c5e09e477.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 70.03891% with 77 lines in your changes missing coverage. Please review.

Project coverage is 48.85%. Comparing base (2941b5c) to head (7c5e09e).

Files with missing lines Patch % Lines
central/metrics/custom.go 20.58% 54 Missing ⚠️
central/metrics/aggregator/common/tracker_base.go 86.25% 12 Missing and 6 partials ⚠️
central/metrics/aggregator/common/config_parser.go 92.10% 2 Missing and 1 partial ⚠️
central/metrics/aggregator/common/condition.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           michael/ROX-28151-aggregator   #15744    +/-   ##
==============================================================
  Coverage                         48.84%   48.85%            
==============================================================
  Files                              2597     2601     +4     
  Lines                            190663   191058   +395     
==============================================================
+ Hits                              93138    93344   +206     
- Misses                            90230    90409   +179     
- Partials                           7295     7305    +10     
Flag Coverage Δ
go-unit-tests 48.85% <70.03%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol parametalol marked this pull request as draft June 17, 2025 13:15
@parametalol parametalol deleted the michael/ROX-28151-tracker branch September 17, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants