Skip to content

ROX-28151: More label condition operators#15710

Closed
parametalol wants to merge 1 commit intomichael/ROX-28151-aggregatorfrom
michael/ROX-28151-more-conditions
Closed

ROX-28151: More label condition operators#15710
parametalol wants to merge 1 commit intomichael/ROX-28151-aggregatorfrom
michael/ROX-28151-more-conditions

Conversation

@parametalol
Copy link
Copy Markdown
Contributor

@parametalol parametalol commented Jun 12, 2025

Description

Adding support for more operators to label condition.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Unit tests.

Current dependencies on/for this PR:

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jun 12, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from 8b3d7e7 to 2c8cbfa Compare June 12, 2025 19:30
@parametalol parametalol force-pushed the michael/ROX-28151-runner branch from c67edfa to 8d7105f Compare June 13, 2025 09:52
@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from 2c8cbfa to 78a7fe4 Compare June 13, 2025 09:59
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Jun 13, 2025

Images are ready for the commit at dabad99.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-64-gdabad990ee.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (michael/ROX-28151-runner@b0f970a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
central/metrics/aggregator/common/condition.go 88.46% 3 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             michael/ROX-28151-runner   #15710   +/-   ##
===========================================================
  Coverage                            ?   48.87%           
===========================================================
  Files                               ?     2604           
  Lines                               ?   191235           
  Branches                            ?        0           
===========================================================
  Hits                                ?    93463           
  Misses                              ?    90460           
  Partials                            ?     7312           
Flag Coverage Δ
go-unit-tests 48.87% <93.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from 78a7fe4 to 9265c3c Compare June 13, 2025 12:19
@parametalol parametalol force-pushed the michael/ROX-28151-runner branch from f06cde8 to fa60bc0 Compare June 13, 2025 12:39
@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from 9265c3c to 42a2282 Compare June 13, 2025 12:39
@parametalol parametalol force-pushed the michael/ROX-28151-runner branch from fa60bc0 to e70cf1b Compare June 13, 2025 14:00
@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from 42a2282 to 46d80c2 Compare June 13, 2025 14:01
@parametalol parametalol force-pushed the michael/ROX-28151-runner branch from e70cf1b to b365301 Compare June 13, 2025 20:23
@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from 46d80c2 to 5c02fe7 Compare June 13, 2025 20:27
@parametalol parametalol force-pushed the michael/ROX-28151-runner branch from b365301 to 4a6e785 Compare June 16, 2025 09:13
@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from 5c02fe7 to abe5795 Compare June 16, 2025 09:15
@parametalol parametalol force-pushed the michael/ROX-28151-runner branch from 4a6e785 to b0f970a Compare June 16, 2025 10:14
@parametalol parametalol force-pushed the michael/ROX-28151-more-conditions branch from abe5795 to dabad99 Compare June 16, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants