ROX-28326: Support for multitenant scraping#15672
Closed
parametalol wants to merge 8 commits intomichael/ROX-28326-expose-cve-metricsfrom
Closed
ROX-28326: Support for multitenant scraping#15672parametalol wants to merge 8 commits intomichael/ROX-28326-expose-cve-metricsfrom
parametalol wants to merge 8 commits intomichael/ROX-28326-expose-cve-metricsfrom
Conversation
|
Skipping CI for Draft Pull Request. |
parametalol
changed the title
Contributor
|
Images are ready for the commit at 71aedc8. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## michael/ROX-28326-expose-cve-metrics #15672 +/- ##
========================================================================
- Coverage 48.22% 48.10% -0.12%
========================================================================
Files 751 751
Lines 75033 74990 -43
========================================================================
- Hits 36186 36077 -109
- Misses 35605 35677 +72
+ Partials 3242 3236 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the HTTP server routing defined in
The
config.protois augmented with registry name and exposure settings. Internal metrics are served on the existing default internal central endpoint. External — on the API endpoint,/metrics/<registry-name>path.This allows users to serve different metrics on different URLs, and configure different Prometheus tenants to scrape from those URLs.
The labels and resource filtering is fully in the hands of the user.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
TBD