Skip to content

ROX-29523: Prometheus metrics configuration UI#15526

Closed
parametalol wants to merge 3 commits intomichael/ROX-28151-runnerfrom
michael/ROX-28326-ui
Closed

ROX-29523: Prometheus metrics configuration UI#15526
parametalol wants to merge 3 commits intomichael/ROX-28151-runnerfrom
michael/ROX-28326-ui

Conversation

@parametalol
Copy link
Copy Markdown
Contributor

@parametalol parametalol commented Jun 2, 2025

Description

The UI part to view and configure the custom Prometheus metrics (private section of the central configuration object).

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

TBD

Screenshot From 2025-06-02 09-52-05
Screenshot From 2025-06-02 09-51-26
Screenshot From 2025-06-02 09-44-37

Current dependencies on/for this PR:

@parametalol parametalol requested a review from a team as a code owner June 2, 2025 08:18
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Jun 2, 2025

Images are ready for the commit at 9c70c47.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-985-g9c70c47cb0.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.80%. Comparing base (d21a272) to head (9c70c47).

Additional details and impacted files
@@                          Coverage Diff                           @@
##           michael/ROX-28326-expose-cve-metrics   #15526    +/-   ##
======================================================================
  Coverage                                 48.80%   48.80%            
======================================================================
  Files                                      2596     2594     -2     
  Lines                                    190726   190507   -219     
======================================================================
- Hits                                      93080    92979   -101     
+ Misses                                    90351    90243   -108     
+ Partials                                   7295     7285    -10     
Flag Coverage Δ
go-unit-tests 48.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol parametalol changed the base branch from michael/ROX-28326-expose-cve-metrics to michael/ROX-28151-runner June 16, 2025 13:53
@RTann RTann removed the request for review from a team June 16, 2025 17:24
@parametalol parametalol marked this pull request as draft June 17, 2025 13:16
@parametalol parametalol deleted the michael/ROX-28326-ui branch September 17, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants