Skip to content

ROX-28326: expose policy violation alerts as prometheus metrics#15392

Closed
parametalol wants to merge 1 commit intomichael/ROX-28326-node-vulnerabilitiesfrom
michael/expose-policy-violations
Closed

ROX-28326: expose policy violation alerts as prometheus metrics#15392
parametalol wants to merge 1 commit intomichael/ROX-28326-node-vulnerabilitiesfrom
michael/expose-policy-violations

Conversation

@parametalol
Copy link
Copy Markdown
Contributor

@parametalol parametalol commented May 21, 2025

Description

Subj.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI
manual tbd

Current dependencies on/for this PR:

@parametalol parametalol requested a review from a team as a code owner May 21, 2025 12:40
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented May 21, 2025

Images are ready for the commit at d4b8326.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-985-gd4b8326bbe.

@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.80%. Comparing base (7e181bf) to head (d4b8326).

Files with missing lines Patch % Lines
central/metrics/aggregator/singleton.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           michael/ROX-28326-node-vulnerabilities   #15392   +/-   ##
=======================================================================
  Coverage                                   48.80%   48.80%           
=======================================================================
  Files                                        2594     2594           
  Lines                                      190516   190525    +9     
=======================================================================
+ Hits                                        92981    92990    +9     
- Misses                                      90250    90253    +3     
+ Partials                                     7285     7282    -3     
Flag Coverage Δ
go-unit-tests 48.80% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol parametalol force-pushed the michael/ROX-28326-expose-cve-metrics branch from ab17f57 to 80dce42 Compare May 27, 2025 19:21
@parametalol parametalol marked this pull request as draft June 3, 2025 14:40
@parametalol parametalol force-pushed the michael/expose-policy-violations branch 3 times, most recently from 3c1e268 to 197af6c Compare June 3, 2025 19:03
@parametalol parametalol changed the base branch from michael/ROX-28326-expose-cve-metrics to michael/ROX-28326-node-vulnerabilities June 3, 2025 19:04
@parametalol parametalol force-pushed the michael/ROX-28326-node-vulnerabilities branch 2 times, most recently from 530ef68 to ca0c8ca Compare June 3, 2025 19:08
@parametalol parametalol force-pushed the michael/expose-policy-violations branch from 197af6c to 6eace1e Compare June 3, 2025 19:09
@parametalol parametalol force-pushed the michael/ROX-28326-node-vulnerabilities branch from ca0c8ca to 7e181bf Compare June 4, 2025 19:29
@parametalol parametalol force-pushed the michael/expose-policy-violations branch from 6eace1e to d4b8326 Compare June 5, 2025 08:20
@parametalol
Copy link
Copy Markdown
Contributor Author

Closed in favour of #16434.

@parametalol parametalol closed this Sep 9, 2025
@parametalol parametalol deleted the michael/expose-policy-violations branch September 17, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants