Skip to content

refactor(glob): pkg/glob moved out of pkg/telemetry/phonehome#15081

Merged
parametalol merged 5 commits intomasterfrom
michael/refactor-pkg-glob
Apr 28, 2025
Merged

refactor(glob): pkg/glob moved out of pkg/telemetry/phonehome#15081
parametalol merged 5 commits intomasterfrom
michael/refactor-pkg-glob

Conversation

@parametalol
Copy link
Copy Markdown
Contributor

@parametalol parametalol commented Apr 24, 2025 •
edited
Loading

Description

Pre-factoring for the second glob client: #15058.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Unit tests.

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @parametalol - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a helper function to construct APICallCampaignCriterion objects in tests to reduce duplication.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Apr 24, 2025 •
edited
Loading

Images are ready for the commit at ca2f4a7.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-359-gfea737a15c.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.48387% with 20 lines in your changes missing coverage. Please review.

Project coverage is 48.98%. Comparing base (cde3b5f) to head (5658fa7).
Report is 187 commits behind head on master.

Files with missing lines Patch % Lines
pkg/glob/pattern.go 39.13% 12 Missing and 2 partials ⚠️
central/telemetry/centralclient/interceptors.go 0.00% 4 Missing ⚠️
pkg/telemetry/phonehome/campaign.go 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #15081      +/-   ##
==========================================
+ Coverage   48.88%   48.98%   +0.10%     
==========================================
  Files        2547     2550       +3     
  Lines      186906   187231     +325     
==========================================
+ Hits        91365    91715     +350     
+ Misses      88309    88262      -47     
- Partials     7232     7254      +22
Flag Coverage Δ
go-unit-tests 48.98% <35.48%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@parametalol parametalol requested a review from a team April 25, 2025 14:40
@janisz
Copy link
Copy Markdown
Contributor

janisz commented Apr 28, 2025

/retest

janisz
janisz reviewed Apr 28, 2025
View reviewed changes
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 28, 2025

@parametalol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-operator-e2e-tests 5658fa7 link false /test ocp-4-12-operator-e2e-tests
ci/prow/gke-sensor-integration-tests ca2f4a7 link false /test gke-sensor-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@parametalol parametalol enabled auto-merge (squash) April 28, 2025 10:21
@parametalol parametalol merged commit 5778bfd into master Apr 28, 2025
78 of 87 checks passed
@parametalol parametalol deleted the michael/refactor-pkg-glob branch April 28, 2025 10:56
vikin91 pushed a commit that referenced this pull request Apr 30, 2025
@parametalol @vikin91
refactor(glob): pkg/glob moved out of pkg/telemetry/phonehome (#1…
95b10c2 
…5081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parametalol @rhacs-bot @janisz