Skip to content

ROX-20769: Use PG15 to run CI#14903

Merged
erthalion merged 3 commits intomasterfrom
feature/pg-15-testing
Apr 28, 2025
Merged

ROX-20769: Use PG15 to run CI#14903
erthalion merged 3 commits intomasterfrom
feature/pg-15-testing

Conversation

@erthalion
Copy link
Copy Markdown
Contributor

@erthalion erthalion commented Apr 7, 2025 •
edited
Loading

Description

Use PostgreSQL 15 for central-db. Benefit from #14447 to handle upgrade scenarios.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI is sufficient.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions github-actions bot added area/helm area/postgres konflux-build Run Konflux in PR. Push commit to trigger it. labels Apr 7, 2025
@erthalion erthalion changed the title Use PG15 to run CI ROX-20769: Use PG15 to run CI Apr 7, 2025
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Apr 7, 2025 •
edited
Loading

Images are ready for the commit at fbace29.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-540-gfbace29b7c.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (042b990) to head (fbace29).
Report is 21 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14903   +/-   ##
=======================================
  Coverage   48.99%   49.00%           
=======================================
  Files        2550     2550           
  Lines      187230   187280   +50     
=======================================
+ Hits        91736    91770   +34     
- Misses      88245    88254    +9     
- Partials     7249     7256    +7
Flag Coverage Δ
go-unit-tests 49.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erthalion erthalion force-pushed the feature/pg-15-testing branch from dc7223b to bd61c58 Compare April 11, 2025 08:32
@erthalion erthalion marked this pull request as ready for review April 11, 2025 13:51
@erthalion erthalion requested a review from a team as a code owner April 11, 2025 13:51
sourcery-ai[bot]
sourcery-ai bot reviewed Apr 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @erthalion - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment explaining why the postgres version is being bumped.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@erthalion erthalion force-pushed the feature/pg-15-testing branch 2 times, most recently from f5dc099 to 109854a Compare April 16, 2025 08:31
@erthalion erthalion force-pushed the feature/pg-15-testing branch from 109854a to 51b2564 Compare April 22, 2025 12:07
@erthalion erthalion requested a review from a team as a code owner April 23, 2025 13:05
@erthalion
Copy link
Copy Markdown
Contributor Author

erthalion commented Apr 24, 2025

/retest

@erthalion erthalion force-pushed the feature/pg-15-testing branch from 28637e9 to bd16801 Compare April 24, 2025 12:27
dashrews78
dashrews78 reviewed Apr 24, 2025
View reviewed changes
dashrews78
dashrews78 reviewed Apr 24, 2025
View reviewed changes
dashrews78
dashrews78 reviewed Apr 24, 2025
View reviewed changes
dashrews78
dashrews78 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dashrews78 dashrews78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple of nits.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 25, 2025

@erthalion: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-upgrade-tests fbace29 link false /test gke-upgrade-tests
ci/prow/gke-scanner-v4-install-tests fbace29 link false /test gke-scanner-v4-install-tests
ci/prow/gke-qa-e2e-tests fbace29 link false /test gke-qa-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests fbace29 link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests fbace29 link false /test ocp-4-12-operator-e2e-tests
ci/prow/ocp-4-12-scanner-v4-install-tests fbace29 link false /test ocp-4-12-scanner-v4-install-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests fbace29 link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-18-qa-e2e-tests fbace29 link false /test ocp-4-18-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@erthalion erthalion merged commit 9b13e84 into master Apr 28, 2025
94 of 116 checks passed
@erthalion erthalion deleted the feature/pg-15-testing branch April 28, 2025 06:42
vikin91 pushed a commit that referenced this pull request Apr 30, 2025
@erthalion @vikin91
ROX-20769: Use PG15 to run CI (#14903)
46d1e26 
Use PostgreSQL 15 for central-db. Benefit from #14447 to handle upgrade scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@dashrews78 dashrews78 dashrews78 approved these changes

Assignees

No one assigned

Labels

area/helm area/postgres konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erthalion @rhacs-bot @dashrews78