Skip to content

ROX-26908: set operator fips-compliant:true [Backport release-4.4]#13945

Merged
daynewlee merged 1 commit intorelease-4.4from
backport-13890-to-release-4.4
Jan 24, 2025
Merged

ROX-26908: set operator fips-compliant:true [Backport release-4.4]#13945
daynewlee merged 1 commit intorelease-4.4from
backport-13890-to-release-4.4

Conversation

@rhacs-bot
Copy link
Copy Markdown
Contributor

@rhacs-bot rhacs-bot commented Jan 23, 2025

Backport 7ac5a11 from #13890.

@github-actions github-actions bot added area/operator backport PR to backport changes from master to release branch labels Jan 23, 2025
@davdhacs davdhacs changed the title [Backport release-4.4] ROX-26908: set operator fips-compliant:true [Backport release-4.5] ROX-26908: set operator fips-compliant:true [Backport release-4.4] Jan 23, 2025
@davdhacs davdhacs requested review from daynewlee and kurlov January 23, 2025 17:51
@rhacs-bot
Copy link
Copy Markdown
Contributor Author

rhacs-bot commented Jan 23, 2025

Images are ready for the commit at ea8f340.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.8-rc.2-4-gea8f3405db.

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 23, 2025

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.77%. Comparing base (6b75c09) to head (ea8f340).

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-4.4   #13945   +/-   ##
============================================
  Coverage        47.77%   47.77%           
============================================
  Files             2503     2503           
  Lines           170960   170960           
============================================
+ Hits             81668    81672    +4     
  Misses           82573    82573           
+ Partials          6719     6715    -4
Flag Coverage Δ
go-unit-tests 47.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 23, 2025

/retest

@davdhacs davdhacs added the auto-retest PRs with this label will be automatically retested if prow checks fails label Jan 23, 2025
@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 24, 2025

/retest

5 similar comments
@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 24, 2025

/retest

@rhacs-bot
Copy link
Copy Markdown
Contributor Author

rhacs-bot commented Jan 24, 2025

/retest

@rhacs-bot
Copy link
Copy Markdown
Contributor Author

rhacs-bot commented Jan 24, 2025

/retest

@rhacs-bot
Copy link
Copy Markdown
Contributor Author

rhacs-bot commented Jan 24, 2025

/retest

@rhacs-bot
Copy link
Copy Markdown
Contributor Author

rhacs-bot commented Jan 24, 2025

/retest

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 24, 2025

It looks like this test gke-qa-e2e has not passed on this branch for many runs (last success Oct 8: https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-stackrox-stackrox-release-4.4-gke-qa-e2e-tests?buildId=1856499610025988096).

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 24, 2025

/test gke-qa-e2e-tests

1 similar comment
@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 24, 2025

/test gke-qa-e2e-tests

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jan 24, 2025

@rhacs-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests ea8f340 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@davdhacs davdhacs added this to the 4.4.8-rc.3 milestone Jan 24, 2025
@davdhacs davdhacs mentioned this pull request Jan 24, 2025
Merged
9 tasks
@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 24, 2025

It looks like this test is permanently failing now on release-4.4.
I cherry-picked some test-flakiness fixes and will see if that fixes it: #13970

daynewlee
daynewlee approved these changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@daynewlee daynewlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge. @kurlov can double check.

@daynewlee daynewlee merged commit 03f1da7 into release-4.4 Jan 24, 2025
@daynewlee daynewlee deleted the backport-13890-to-release-4.4 branch January 24, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daynewlee daynewlee daynewlee approved these changes

@kurlov kurlov kurlov approved these changes

Assignees

No one assigned

Labels

area/operator auto-retest PRs with this label will be automatically retested if prow checks fails backport PR to backport changes from master to release branch

Projects

None yet

Milestone

4.4.8-rc.3

Development

Successfully merging this pull request may close these issues.

4 participants

@rhacs-bot @davdhacs @daynewlee @kurlov