Skip to content

ROX-26908: set operator fips-compliant:true [Backport release-4.6]#13866

Merged
janisz merged 3 commits intorelease-4.6from
backport-13219-to-release-4.6
Feb 27, 2025
Merged

ROX-26908: set operator fips-compliant:true [Backport release-4.6]#13866
janisz merged 3 commits intorelease-4.6from
backport-13219-to-release-4.6

Conversation

@rhacs-bot
Copy link
Copy Markdown
Contributor

@rhacs-bot rhacs-bot commented Jan 17, 2025

Backport d0c43be from #13219.

@rhacs-bot rhacs-bot requested a review from a team as a code owner January 17, 2025 18:03
@rhacs-bot rhacs-bot requested review from GrimmiMeloni and removed request for a team January 17, 2025 18:03
@github-actions github-actions bot added area/operator backport PR to backport changes from master to release branch labels Jan 17, 2025
@davdhacs davdhacs requested a review from daynewlee January 17, 2025 18:05
@davdhacs davdhacs marked this pull request as draft January 17, 2025 18:13
@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Jan 17, 2025

Converted to draft until 4.6.2 is complete (cannot merge to the release-4.6 branch until 4.6.2 is release-complete because it always uses the head of the branch).

@rhacs-bot
Copy link
Copy Markdown
Contributor Author

rhacs-bot commented Jan 17, 2025 •
edited
Loading

Images are ready for the commit at 4e75d5f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.3-rc.1-3-g4e75d5f62e.

@davdhacs davdhacs changed the title [Backport release-4.6] ROX-26908: set operator fips-compliant:true ROX-26908: set operator fips-compliant:true [Backport release-4.6] Jan 20, 2025
@davdhacs davdhacs marked this pull request as ready for review February 6, 2025 18:12
@davdhacs davdhacs added this to the 4.6.3-rc.1 milestone Feb 6, 2025
@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Feb 14, 2025

/retest

@davdhacs davdhacs force-pushed the backport-13219-to-release-4.6 branch from bd8ad2e to 7d92157 Compare February 14, 2025 14:37
@davdhacs davdhacs added the auto-retest PRs with this label will be automatically retested if prow checks fails label Feb 14, 2025
@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Feb 14, 2025

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.42%. Comparing base (fbac7a6) to head (4e75d5f).
Report is 3 commits behind head on release-4.6.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-4.6   #13866      +/-   ##
===============================================
- Coverage        48.42%   48.42%   -0.01%     
===============================================
  Files             2469     2469              
  Lines           178501   178501              
===============================================
- Hits             86442    86439       -3     
- Misses           85107    85110       +3     
  Partials          6952     6952
Flag Coverage Δ
go-unit-tests 48.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Feb 18, 2025

/retest-required

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Feb 19, 2025

/retest

@davdhacs davdhacs mentioned this pull request Feb 20, 2025
Merged
@davdhacs davdhacs requested review from ebensh and janisz and removed request for GrimmiMeloni and daynewlee February 20, 2025 20:56
@github-actions github-actions bot removed this from the 4.6.3-rc.1 milestone Feb 25, 2025
@github-actions github-actions bot added this to the 4.6.3-rc.2 milestone Feb 25, 2025
@janisz
Copy link
Copy Markdown
Contributor

janisz commented Feb 25, 2025

/retest

1 similar comment
@janisz
Copy link
Copy Markdown
Contributor

janisz commented Feb 25, 2025

/retest

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Feb 25, 2025

It looks like this test is still flakey after the back-ported possible fix. I see it failing across other release pr's. https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-stackrox-stackrox-release-4.6-gke-qa-e2e-tests

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Feb 25, 2025

/retest

@davdhacs
Copy link
Copy Markdown
Contributor

davdhacs commented Feb 26, 2025

@janisz I merged the updated target branch and it looks like this is passing now.

@github-actions github-actions bot modified the milestones: 4.6.3-rc.2, 4.6.3-rc.3 Feb 27, 2025
@janisz janisz merged commit 503dda9 into release-4.6 Feb 27, 2025
80 of 89 checks passed
@janisz janisz deleted the backport-13219-to-release-4.6 branch February 27, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@ebensh ebensh Awaiting requested review from ebensh

Assignees

No one assigned

Labels

area/operator auto-retest PRs with this label will be automatically retested if prow checks fails backport PR to backport changes from master to release branch

Projects

None yet

Milestone

4.6.3-rc.3

Development

Successfully merging this pull request may close these issues.

3 participants

@rhacs-bot @davdhacs @janisz