Skip to content

chore: bump helm-operator-plugins (and k8s to 1.30)#12614

Merged
porridge merged 9 commits intomasterfrom
porridge/bump-helm-operator
Sep 17, 2024
Merged

chore: bump helm-operator-plugins (and k8s to 1.30)#12614
porridge merged 9 commits intomasterfrom
porridge/bump-helm-operator

Conversation

@porridge
Copy link
Contributor

@porridge porridge commented Sep 5, 2024 •
edited
Loading

Description

Fixes https://issues.redhat.com/browse/ROX-25599

TODO:

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI is enough.

@porridge porridge requested a review from a team as a code owner September 5, 2024 08:48
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 5, 2024 •
edited
Loading

Images are ready for the commit at 41b7f6c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-501-g41b7f6cf79.

@porridge porridge force-pushed the porridge/bump-helm-operator branch from 982ce6f to 817d202 Compare September 12, 2024 10:32
@porridge porridge force-pushed the porridge/bump-helm-operator branch from 4a24249 to 47aa2ad Compare September 12, 2024 12:50
@porridge porridge changed the title chore: bump helm-operator-plugins chore: bump helm-operator-plugins (and k8s to 1.30) Sep 12, 2024
@porridge porridge added the auto-retest PRs with this label will be automatically retested if prow checks fails label Sep 12, 2024
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 12, 2024 •
edited
Loading

Images are ready for the commit at 114a614.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-502-g114a614449.

@codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.18%. Comparing base (bfaaabd) to head (114a614).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
operator/internal/utils/predicates.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12614      +/-   ##
==========================================
- Coverage   48.19%   48.18%   -0.01%     
==========================================
  Files        2434     2434              
  Lines      173898   173898              
==========================================
- Hits        83805    83801       -4     
- Misses      83337    83338       +1     
- Partials     6756     6759       +3
Flag Coverage Δ
go-unit-tests 48.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 12, 2024

/retest

2 similar comments
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 12, 2024

/retest

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Sep 12, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2024 •
edited
Loading

@porridge: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-scanner-v4-tests 982ce6f link false /test ocp-4-12-scanner-v4-tests
ci/prow/ocp-4-16-scanner-v4-tests 982ce6f link false /test ocp-4-16-scanner-v4-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@porridge
Copy link
Contributor Author

porridge commented Sep 16, 2024

/retest

@porridge porridge mentioned this pull request Sep 16, 2024
Closed
RTann
RTann reviewed Sep 17, 2024
View reviewed changes
@porridge porridge merged commit c28ea50 into master Sep 17, 2024
@porridge porridge deleted the porridge/bump-helm-operator branch September 17, 2024 04:51
acravn pushed a commit to acravn/stackrox that referenced this pull request Sep 20, 2024
@porridge
chore: bump helm-operator-plugins (and k8s to 1.30) (stackrox#12614)
48b5bbc
shireenf-ibm pushed a commit to shireenf-ibm/stackrox that referenced this pull request Sep 25, 2024
@porridge @shireenf-ibm
chore: bump helm-operator-plugins (and k8s to 1.30) (stackrox#12614)
ce9a397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@vladbologa vladbologa Awaiting requested review from vladbologa

@mclasmeier mclasmeier Awaiting requested review from mclasmeier

+1 more reviewer

@RTann RTann RTann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/operator area/scanner auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@porridge @rhacs-bot @janisz @RTann